Closed
Bug 771876
Opened 12 years ago
Closed 11 years ago
make "find on the page" search in a standalone SVG document
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
DUPLICATE
of bug 599804
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
1.43 KB,
patch
|
asaf
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #640028 -
Flags: review?(dao)
Assignee | ||
Comment 1•12 years ago
|
||
review ping?
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → cam
Status: NEW → ASSIGNED
Updated•12 years ago
|
Attachment #640028 -
Flags: review?(dao) → review?(mano)
Comment 2•12 years ago
|
||
Comment on attachment 640028 [details] [diff] [review] patch 1. Save the following in a .svg file: <?xml version="1.0" standalone="yes"?> <svg width="4in" height="3in" version="1.1" xmlns = 'http://www.w3.org/2000/svg'> <text font-size="10" font-family="Verdana"> <tspan x="100" y="100">FindMe</tspan> </text> </svg> With your patch applied, load the file and search for FindMe. Here I see that the find bar behaves as if it found the text, but the found text is not selected. This makes sense considering that you cannot select this text (Bug 292498). For what it's worth, edit commands suffer from the same sort of bugs - copy/select all works, but there's no visual feedback. This is not intended though, it's just that no one bothered to disable this command until bug 292498 is fixed.
Attachment #640028 -
Flags: review?(mano) → review-
Comment 3•12 years ago
|
||
Geez, you could mention in comment 0 that you're aware of this issue! I just noticed your comment on bug 330045, pointing to your awesome work on bug 655877 :) So taking back my review, of course. But please set the request after bug 655877 lands. Apology and thanks!
Comment 4•12 years ago
|
||
Comment on attachment 640028 [details] [diff] [review] patch By the way, this needs a test. You can easily create one based on the general findbar-widget test. It would be nice to test foreignObjects as well.
Attachment #640028 -
Flags: review- → feedback+
Assignee | ||
Comment 5•12 years ago
|
||
Ow, I'm sorry Mano, I should definitely have mentioned that this depends on the bug 655877 work to actually render the find highlights. I'll make some tests like you suggest too.
Updated•11 years ago
|
Assignee | ||
Comment 6•11 years ago
|
||
Bug 599804 made this work, so nothing to do here now.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•