771876 - make "find on the page" search in a standalone SVG document

Status: RESOLVED DUPLICATE of bug 599804

(Toolkit :: Find Toolbar, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 1

[Cameron McCormack (:heycam)]

review ping?

Comment 2

[Asaf Romano (gone)]

Comment on attachment 640028 [details] [diff] [review]
patch

1. Save the following in a .svg file:

<?xml version="1.0" standalone="yes"?>
<svg width="4in" height="3in" version="1.1"
 xmlns = 'http://www.w3.org/2000/svg'>
    <text font-size="10" font-family="Verdana">
      <tspan x="100" y="100">FindMe</tspan>
    </text>
</svg>

With your patch applied, load the file and search for FindMe.

Here I see that the find bar behaves as if it found the text, but the found text is not selected. This makes sense considering that you cannot select this text (Bug 292498).

For what it's worth, edit commands suffer from the same sort of bugs - copy/select all works, but there's no visual feedback. This is not intended though, it's just that no one bothered to disable this command until bug 292498 is fixed.

Comment 3

[Asaf Romano (gone)]

Geez, you could mention in comment 0 that you're aware of this issue! I just noticed your comment on bug 330045, pointing to your awesome work on bug 655877 :)

So taking back my review, of course. But please set the request after bug 655877 lands. Apology and thanks!

Comment 4

[Asaf Romano (gone)]

Comment on attachment 640028 [details] [diff] [review]
patch

By the way, this needs a test. You can easily create one based on the general findbar-widget test. It would be nice to test foreignObjects as well.

Comment 5

[Cameron McCormack (:heycam)]

Ow, I'm sorry Mano, I should definitely have mentioned that this depends on the bug 655877 work to actually render the find highlights.  I'll make some tests like you suggest too.

Comment 6

[Cameron McCormack (:heycam)]

Bug 599804 made this work, so nothing to do here now.