599804 - Highlight all doesn't work with non HTML documents (e.g. CSS styled XML files)

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Takeshi Kurosawa :takenspc]

Highlight all doesn't work with non HTML documents even if the term hits when using normal search.

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Patch

Use doc.documentElement when doc.body doesn't exist.

This also works with the testcase of bug 495141.

Comment 2

[[:Aleksej]]

Hi.  You needed to request a review.

There is an older bug on this: bug 253261.

Comment 3

[Nickolay_Ponomarev]

Comment on attachment 478723 [details] [diff] [review]
Patch

> Hi.  You needed to request a review.
...it's also better to request it from a specific person. Tagging adw, since the last review in this file was his.

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 478723 [details] [diff] [review]
Patch

Review of attachment 478723 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, Takeshi, and thanks for the review redirection, Nickolay.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c7c1df9dc9b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c7c1df9dc9b