Closed
Bug 599804
Opened 14 years ago
Closed 12 years ago
Highlight all doesn't work with non HTML documents (e.g. CSS styled XML files)
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: takenspc, Assigned: takenspc)
References
()
Details
Attachments
(1 file)
1.15 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
Highlight all doesn't work with non HTML documents even if the term hits when using normal search.
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Comment 1•14 years ago
|
||
Use doc.documentElement when doc.body doesn't exist. This also works with the testcase of bug 495141.
Comment 2•12 years ago
|
||
Hi. You needed to request a review. There is an older bug on this: bug 253261.
Updated•12 years ago
|
Attachment #478723 -
Flags: review?
Comment 3•12 years ago
|
||
Comment on attachment 478723 [details] [diff] [review] Patch > Hi. You needed to request a review. ...it's also better to request it from a specific person. Tagging adw, since the last review in this file was his.
Attachment #478723 -
Flags: review? → review?(adw)
Comment 4•12 years ago
|
||
Comment on attachment 478723 [details] [diff] [review] Patch Review of attachment 478723 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch, Takeshi, and thanks for the review redirection, Nickolay.
Attachment #478723 -
Flags: review?(adw) → review+
Updated•12 years ago
|
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c7c1df9dc9b
Assignee: nobody → taken.spc
Keywords: checkin-needed
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2c7c1df9dc9b
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•