771975 - Remove -moz-prefixed gradients usage from the tree

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Masatoshi Kimura [:emk]]

Some callers use position+angle gradient lines in linear-gradients which unprefixed syntax does not support.
https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/inContentUI.css?rev=f4157e8c4107#52
https://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/browser.css?rev=7c1d395ebab7#1859
https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser.css?rev=7c1d395ebab7#2579
https://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser.css?rev=7c1d395ebab7#2516
How can I replace them?

Comment 1

[Dão Gottwald [:dao]]

(In reply to Masatoshi Kimura [:emk] from comment #0)
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/
> browser.css?rev=7c1d395ebab7#1859
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/
> browser.css?rev=7c1d395ebab7#2579
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/
> browser.css?rev=7c1d395ebab7#2516

Removed in bug 774298.

Comment 2

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Changes in devtools

At least in FF 20 there are still some -moz prefixed gradients (and some other stuff as well) in the devtools, which cause the theme validation to warn when including these into an theme for AMO.

The attatched file are the changes that were required in the devtools folder for me (from a plain FF20 copy) to not have warnings when uploading. Maybe it helps somebody :)

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from b2g

Please do not accept a patch containing -moz-preixed gradients anymore.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from devtools

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from browser and toolkit

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from android

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from rest of the tree

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

testing/xpcshell/node-spdy looks like imported code, fwiw

Comment 9

[Masatoshi Kimura [:emk]]

Attachment: Remove -moz-prefixed gradients usage from devtools, v2

Rebased

Comment 10

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7177dae62b2f

Comment 11

[Masatoshi Kimura [:emk]]

(In reply to :Ms2ger from comment #8)
> testing/xpcshell/node-spdy looks like imported code, fwiw

Sent a PR upstream.
https://github.com/indutny/node-spdy/pull/84

Comment 12

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d842380959

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7177dae62b2f
https://hg.mozilla.org/mozilla-central/rev/b0d842380959

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 734364 [details] [diff] [review]
Remove -moz-prefixed gradients usage from rest of the tree

Review of attachment 734364 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why we actually have this node-spdy example in our tree... Maybe we should remove it?

Comment 15

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/200eab5fa1ed
https://hg.mozilla.org/integration/mozilla-inbound/rev/17c32b5e6461
https://hg.mozilla.org/integration/mozilla-inbound/rev/434c6e694813

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/200eab5fa1ed
https://hg.mozilla.org/mozilla-central/rev/17c32b5e6461
https://hg.mozilla.org/mozilla-central/rev/434c6e694813

Comment 17

[Masatoshi Kimura [:emk]]

The comment #0 problem is unresolved yet :(
https://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/inContentUI.css?rev=7177dae62b2f#51

Comment 18

[Masatoshi Kimura [:emk]]

Apparently this is already fixed. -moz-(linear|radial)-gradient is no longer used in the tree except for tests.