Closed Bug 771975 Opened 7 years ago Closed 5 years ago

Remove -moz-prefixed gradients usage from the tree

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: emk, Assigned: emk)

References

()

Details

(Whiteboard: [leave open])

Attachments

(6 files, 1 obsolete file)

Depends on: 774298
(In reply to Masatoshi Kimura [:emk] from comment #0)
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/gnomestripe/
> browser.css?rev=7c1d395ebab7#1859
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/
> browser.css?rev=7c1d395ebab7#2579
> https://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/
> browser.css?rev=7c1d395ebab7#2516

Removed in bug 774298.
Depends on: 818660
At least in FF 20 there are still some -moz prefixed gradients (and some other stuff as well) in the devtools, which cause the theme validation to warn when including these into an theme for AMO.

The attatched file are the changes that were required in the devtools folder for me (from a plain FF20 copy) to not have warnings when uploading. Maybe it helps somebody :)
Please do not accept a patch containing -moz-preixed gradients anymore.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #734359 - Flags: review?(fabrice)
Attachment #734361 - Flags: review?(vporof)
Attachment #734363 - Flags: review?(mark.finkle)
testing/xpcshell/node-spdy looks like imported code, fwiw
Rebased
Attachment #734361 - Attachment is obsolete: true
Attachment #734361 - Flags: review?(vporof)
Attachment #734367 - Flags: review?(vporof)
Attachment #734362 - Flags: review?(gavin.sharp) → review+
Attachment #734362 - Flags: checkin+
(In reply to :Ms2ger from comment #8)
> testing/xpcshell/node-spdy looks like imported code, fwiw

Sent a PR upstream.
https://github.com/indutny/node-spdy/pull/84
Attachment #734363 - Flags: review?(mark.finkle) → review+
Attachment #734363 - Flags: checkin+
Attachment #734367 - Flags: review?(vporof) → review+
Attachment #734359 - Flags: review?(fabrice) → review+
Comment on attachment 734364 [details] [diff] [review]
Remove -moz-prefixed gradients usage from rest of the tree

Review of attachment 734364 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know why we actually have this node-spdy example in our tree... Maybe we should remove it?
Attachment #734364 - Flags: review?(roc) → review+
Apparently this is already fixed. -moz-(linear|radial)-gradient is no longer used in the tree except for tests.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1176496
You need to log in before you can comment on or make changes to this bug.