Last Comment Bug 818660 - Un-prefix gradients from about:home page contents
: Un-prefix gradients from about:home page contents
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 20
Assigned To: Soumya Deb [:Debloper]
Depends on:
Blocks: 771975 818659
  Show dependency treegraph
Reported: 2012-12-05 13:10 PST by Soumya Deb [:Debloper]
Modified: 2012-12-09 10:50 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch file (4.66 KB, patch)
2012-12-05 13:23 PST, Soumya Deb [:Debloper]
dao+bmo: review-
Details | Diff | Splinter Review
Patch file (4.68 KB, patch)
2012-12-06 10:17 PST, Soumya Deb [:Debloper]
dao+bmo: review+
Details | Diff | Splinter Review

Description Soumya Deb [:Debloper] 2012-12-05 13:10:45 PST
The -moz prefixes are no longer required with CSS linear-gradients for Firefox 16+, so it's safe to remove the prefixes and use the standard syntax for the landing about:home page.
Comment 1 Soumya Deb [:Debloper] 2012-12-05 13:23:35 PST
Created attachment 688931 [details] [diff] [review]
Patch file
Comment 2 Dão Gottwald [:dao] 2012-12-05 14:39:28 PST
Comment on attachment 688931 [details] [diff] [review]
Patch file

> body[narrow] #restorePreviousSessionSeparator {
>   margin: 0 auto;
>   width: 512px;
>   height: 3px;
>-  background-image: -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>-                    -moz-linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>-                    -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));
>+  background-image: linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>+                    linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>+                    linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));

This is invalid syntax for linear-gradient. I believe linear-gradient(to right, ...) is what you want here.
Comment 3 Soumya Deb [:Debloper] 2012-12-06 10:17:45 PST
Created attachment 689265 [details] [diff] [review]
Patch file

Yep, yep - my bad!
Updated. :)

P.S: Does it require explicit ui-review?
Which other approvals (aurora/beta etc.) should I ask for it?
Comment 4 Masatoshi Kimura [:emk] 2012-12-06 18:10:52 PST
Do you have any idea simulating Aero-style light beams using the new syntax?
Comment 5 Dão Gottwald [:dao] 2012-12-07 02:58:25 PST
Comment on attachment 689265 [details] [diff] [review]
Patch file

Comment 6 Dão Gottwald [:dao] 2012-12-07 02:59:03 PST
(In reply to Soumya Deb [:Debloper] from comment #3)
> P.S: Does it require explicit ui-review?


> Which other approvals (aurora/beta etc.) should I ask for it?

None. This only needs to land on mozilla-central.

Note You need to log in before you can comment on or make changes to this bug.