Un-prefix gradients from about:home page contents

RESOLVED FIXED in Firefox 20

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Debloper, Assigned: Debloper)

Tracking

Trunk
Firefox 20
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
The -moz prefixes are no longer required with CSS linear-gradients for Firefox 16+, so it's safe to remove the prefixes and use the standard syntax for the landing about:home page.
(Assignee)

Updated

5 years ago
Assignee: nobody → debloper
Blocks: 818659
(Assignee)

Updated

5 years ago
No longer blocks: 818659
(Assignee)

Comment 1

5 years ago
Created attachment 688931 [details] [diff] [review]
Patch file
Attachment #688931 - Flags: ui-review?(dao)
Attachment #688931 - Flags: review?(dao)
(Assignee)

Updated

5 years ago
Blocks: 818659
Comment on attachment 688931 [details] [diff] [review]
Patch file

> body[narrow] #restorePreviousSessionSeparator {
>   margin: 0 auto;
>   width: 512px;
>   height: 3px;
>-  background-image: -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>-                    -moz-linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>-                    -moz-linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));
>+  background-image: linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0)),
>+                    linear-gradient(0, hsla(211,79%,6%,0), hsla(211,79%,6%,.2), hsla(211,79%,6%,0)),
>+                    linear-gradient(0, hsla(0,0%,100%,0), hsla(0,0%,100%,.35), hsla(0,0%,100%,0));

This is invalid syntax for linear-gradient. I believe linear-gradient(to right, ...) is what you want here.
Attachment #688931 - Flags: ui-review?(dao)
Attachment #688931 - Flags: review?(dao)
Attachment #688931 - Flags: review-
(Assignee)

Comment 3

5 years ago
Created attachment 689265 [details] [diff] [review]
Patch file

Yep, yep - my bad!
Updated. :)

P.S: Does it require explicit ui-review?
Which other approvals (aurora/beta etc.) should I ask for it?
Attachment #688931 - Attachment is obsolete: true
Attachment #689265 - Flags: review?(dao)
Do you have any idea simulating Aero-style light beams using the new syntax?
Blocks: 771975
Comment on attachment 689265 [details] [diff] [review]
Patch file

Thanks!
Attachment #689265 - Flags: review?(dao) → review+
(In reply to Soumya Deb [:Debloper] from comment #3)
> P.S: Does it require explicit ui-review?

nope

> Which other approvals (aurora/beta etc.) should I ask for it?

None. This only needs to land on mozilla-central.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cfe42934c8f
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2cfe42934c8f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.