772017 - Have the visual overflow rect for SVG frames include non-rendered stroke when 'pointer-events' demands it

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

For certain vales of 'pointer-events' we need the visual overflow rect for SVG frames to include stroke geometry regardless of whether the stroke is 'none' (doesn't render anything) or not. If the VORs doesn't include stroke in these cases, then we can't use the VORs of SVG frames to short circuit hit-testing.

This is required both for the patch Nick Cameron is working on in bug 762647, and for my work in bug 614732 to do hit-testing of SVG via display lists.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

We can do this because nsSVGPathGeometryFrame::DidSetStyleContext will cause a reflow (UpdateBounds) of the SVG if pointer-events changes.

Comment 2

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8774a43f10bf

Comment 3

[Jonathan Watt [:jwatt]]

Hmm, this patch is not sufficient. Will follow up tomorrow.

Comment 4

[Jonathan Watt [:jwatt]]

To be more specific, some of the tens of thousands of tests run by content/svg/content/test/test_pointer-events.xhtml still fail.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8774a43f10bf

Comment 6

[Jonathan Watt [:jwatt]]

Attachment: patch 2

This patch makes sure we also ignore things like stroke-opacity when pointer-events demands it, and fixes nsSVGGlyphFrame too.

Comment 7

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfc3490136e

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9bfc3490136e