The default bug view has changed. See this FAQ.

Make nsSVGGlyphFrame::UpdateBounds reuse GetBBoxContribution

RESOLVED FIXED in mozilla16

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
nsSVGGlyphFrame::UpdateBounds should reuse GetBBoxContribution instead of duplicating code.
(Assignee)

Comment 1

5 years ago
Created attachment 640577 [details] [diff] [review]
patch

I'm doing this separately from bug 772017, and passing flags to GetBBoxContribution that are consistent with what the code does now, even though I'm going to change them in bug 772017. This is because - although I think the patch is okay - there are so many layers of indirection in the nsSVGGlyphFrame code that it's hard to be totally sure. I want this separate patch that's as consistent with what we do now as possible so any regressions that might be caused by using GetBBoxContribution can be squarely blamed on this bug, and not flag changes.
Attachment #640577 - Flags: review?(roc)
Attachment #640577 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cb90658bd51
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/9cb90658bd51
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.