Closed Bug 772046 Opened 10 years ago Closed 10 years ago

ASan builds broken by WebRTC (Linker relocation error)

Categories

(Core :: WebRTC, defect)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: decoder, Assigned: espindola)

Details

(Keywords: sec-want, Whiteboard: [asan][asan-build-blocker][qa-])

Some change that landed on mozilla-central between July 8, 4:10 AM PDT and July 9, 4:10 AM PDT broke the automated AdressSanitizer builds:

/usr/bin/ld: ../../media/webrtc/trunk/src/modules/modules_rtp_rtcp/rtp_rtcp/source/rtp_packet_history.o: relocation R_X86_64_PC32 against `_ZNSt6vectorIjSaIjEE14_M_fill_insertEN9__gnu_cxx17__normal_iteratorIPjS1_EEmRKj' can not be used when making a shared object; recompile with -fPIC


The full build log is here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/choller@mozilla.com-a51d661b6650/try-linux64/try-linux64-bm14-try1-build8272.txt.gz


@Randall: Ms2ger on IRC suggested that this is related to some change that you made recently, is that likely?
Related to webrtc preffing on over the weekend, yes, but glandium thinks there's a missing file in config/system-headers.  Since all the ones included in rt_packet_history.cc or included from it seem to be normal (cstring/cstddef/map/assert), and it doesn't happen in normal builds, the suspicion is that ASan adds some headers(?)

Someone who knows ASan should look at this.
I am unable to reproduce it locally without patching and try will not give me the patch. Can you add instructions on how to reproduce the problem to this bug.
Yea seems like try is having problems. The patch that the autobuild script pushes to try is here:

http://users.own-hero.net/~decoder/asan-try.patch
Note, this could be a clang issue of some sort (not necessarily due to asan).
ok, I am taking a look at it. The build is still going, but I can reproduce the relocations.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
(In reply to Rafael Ávila de Espíndola (:espindola) from comment #5)
> ok, I am taking a look at it. The build is still going, but I can reproduce
> the relocations.

Thanks Rafael :) Meanwhile I modified the patch to use --disable-webrtc to keep the daily builds running, and that works fine for now.
Thanks for the bug report. It does look like a clang issue. I think I fixed it in 160034. I am giving in some extra testing and will let you know when the new package is available on tooltool.
Decoder, there is a new clang manifest in bug 772853. Would you mind trying it to see if it fixes the build for you?
Thanks Rafael, this is fixed with the most recent clang version :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [asan][asan-build-blocker] → [asan][asan-build-blocker][qa-]
You need to log in before you can comment on or make changes to this bug.