772108 - [homepage] Links to Verbatim locale pages from Team pages

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P2)

Description

[Peter Bengtsson [:peterbe]]

On the Team page, we should link to the equivalent Verbatim page. 

We might need to maintain a list of conversion rules and exceptions (e.g. pt-BR (elmo) --> pt_BR (verbatim))

Comment 1

[Axel Hecht [:Pike]]

There is some overlap in data with webby here, in particular with locales.

Also, not sure how much this can share with sumo/mdn hook-up.

Comment 2

[Peter Bengtsson [:peterbe]]

To solve the "conversion", we have to manually write down the conversions in a list. 

Also, perhaps we need a management command to debug which ones are missing. 

Having >1 external links in the Team page sub-nav might excalate the challenge of that CSS problem.

Comment 3

[Peter Bengtsson [:peterbe]]

Attachment: Link to verbatim locale pages

I wrote a scraper to pull down all locales from Verbatim and then compared them with another script. 

Should I maybe turn all of that into a management command for future references?

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 662261 [details] [diff] [review]
Link to verbatim locale pages

Review of attachment 662261 [details] [diff] [review]:
-----------------------------------------------------------------

I like the idea, but I have nits.

When looking up locale codes, could you replace '-' with '_' first? That's the general web locale code -> glibc locale code process to begin with.

Also, I wonder if we should do 

gliblocale = settings.VERBATIM_CONVERSIONS.get(code, code)
if gliblocale:
else
  verbatimurl = None

and set the value to None in VERBATIM_CONVERSIONS for non-existing locales.

We should have that data alphabetically sorted, at least, too.

And yes, I'd love to see a management command to cross-check the locale lists on both sides.

Comment 5

[Peter Bengtsson [:peterbe]]

Attachment: Implement all items from the review

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 663549 [details] [diff] [review]
Implement all items from the review

Review of attachment 663549 [details] [diff] [review]:
-----------------------------------------------------------------

Two nits: We should make the pyquery dependency explicit in requirements/dev.txt, and make the command fail only at runtime if it's not there. And the command should have a help text.

With those, r=me.

::: apps/homepage/management/commands/verbatim-codes-check.py
@@ +16,5 @@
> +try:
> +    from pyquery import PyQuery as pq
> +except ImportError, exc:
> +    exc.args = tuple(['%s (tip: `pip install pyquery`)' % exc.args[0]])
> +    raise

Move this into the handle function itself? Then we can get this command listed even if the import fails.

@@ +20,5 @@
> +    raise
> +
> +
> +class Command(BaseCommand):  # pragma: no cover
> +

Add a help = '' here, too? Might be a good place to mention the pyquery dependency.

Comment 7

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/baa0b24c20e61d2ce81b5ae3136b9130a04e7550
bug 772108 - Verbatim links on the locale pages, r=Pike