Disable GeckoInputConnection's clampSelection() to test whether SpannableStringBuilder IndexOutOfBoundsExceptions are fixed

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
Keyboards and IME
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Depends on: 2 bugs)

unspecified
Firefox 17
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I fixed a Gecko/IME race condition in bug 769520 that was the likely cause of most of the mysterious selection IndexOutOfBoundsExceptions thrown from android.text.SpannableStringBuilder.

To test my hypothesis, I would like to disable GeckoInputConnection's clampSelection() code and watch Socorro topcrashes for IndexOutOfBoundsExceptions regressions. If the exceptions do not return, I'd like to remove the clampSelection() code.
(Assignee)

Updated

5 years ago
Priority: -- → P2
(Assignee)

Comment 1

5 years ago
Created attachment 644015 [details] [diff] [review]
remove-some-clampSelections.patch

Remove some clampSelection() calls to test whether IndexOutOfBoundsExceptions have been fixed by bug 769520.
Attachment #644015 - Flags: review?(blassey.bugs)
Attachment #644015 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f770754fa9e
status-firefox17: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/6f770754fa9e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.