Way to test options passed to main

RESOLVED FIXED

Status

Add-on SDK
General
P2
normal
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: irakli, Assigned: erikvold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We had a regression recently in one of the options passed to main function (see Bug 771825). Unfortunately we don't have infrastructure to have tests for that. We need to build one.

Updated

6 years ago
Priority: -- → P2
bug 745877 would handle this use case
So we have the test infrastructure for this now, but do we still support the main function?
Flags: needinfo?(rFobic)
It's deprecated, but still there
Flags: needinfo?(rFobic)
Assignee: nobody → evold
OS: Mac OS X → All
Hardware: x86 → All
Created attachment 740646 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/960

Pointer to Github pull-request
Attachment #740646 - Flags: review?(zer0)
https://addons.mozilla.org/en-US/developers/docs/sdk/1.12/dev-guide/tutorials/load-and-unload.html
Comment on attachment 740646 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/960

This pull request is now 3 months old, I'm giving it to someone else.
Attachment #740646 - Flags: review?(zer0) → review?(jsantell)
Comment on attachment 740646 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/960

Some nits in the PR, but tests look good
Attachment #740646 - Flags: review?(jsantell) → review+

Comment 8

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/b909978ac8fc8ff30f202768f5c043cd874ae4b7
Bug 772233: basic tests for exports.main in main.js

https://github.com/mozilla/addon-sdk/commit/6fc0a7e6c3ae96ad9cba6a82dce356cc09c31767
Merge pull request #960 from erikvold/772233

Bug 772233: basic tests for exports.main in main.js r=@jsantell

Updated

5 years ago
Depends on: 897683
I'm going through the list of open bugs that github robot has commented in. Is this bug fixed, Erik?
Flags: needinfo?(evold)
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(evold)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.