Make hal/ warning free

RESOLVED FIXED in mozilla16

Status

()

Product:
Core
Component:
Hardware Abstraction Layer (HAL)
RESOLVED FIXED
Reported:
5 years ago
Modified:
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Version:
Trunk
Target:
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Patch
1.58 KB, patch
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
5 years ago 
We should add FAIL_ON_WARNINGS = 1 to hal/Makefile.in to make sure the directory stays warning-free.
(Assignee)

Comment 1

•
5 years ago 
Naive attempt here: https://tbpl.mozilla.org/?tree=Try&rev=b7bc387be59b
Depends on: 772524
 (Assignee)

Comment 2

•
5 years ago 
All builds are okay except on MacOS. Hopefully that one will be green:
https://tbpl.mozilla.org/?tree=Try&rev=649ecfa1f675 (it is including the two smslib fixes)
 (Assignee)

Comment 3

•
5 years ago 
Created attachment 640997 [details] [diff] [review]
Patch

This is passing try.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #640997 - Flags: review?(justin.lebar+bug)
Attachment #640997 - Flags: review?(justin.lebar+bug) → review+
 (Assignee)

Updated

•
5 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla16

Comment 4

•
5 years ago 
https://hg.mozilla.org/mozilla-central/rev/322ef042e1d2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.