Closed Bug 772373 Opened 8 years ago Closed 8 years ago

Make hal/ warning free

Categories

(Core :: Hardware Abstraction Layer (HAL), defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

We should add FAIL_ON_WARNINGS = 1 to hal/Makefile.in to make sure the directory stays warning-free.
Depends on: 772524
All builds are okay except on MacOS. Hopefully that one will be green:
https://tbpl.mozilla.org/?tree=Try&rev=649ecfa1f675 (it is including the two smslib fixes)
Attached patch PatchSplinter Review
This is passing try.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #640997 - Flags: review?(justin.lebar+bug)
Attachment #640997 - Flags: review?(justin.lebar+bug) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/322ef042e1d2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.