Closed
Bug 772373
Opened 8 years ago
Closed 8 years ago
Make hal/ warning free
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Core
Hardware Abstraction Layer (HAL)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
1.58 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
We should add FAIL_ON_WARNINGS = 1 to hal/Makefile.in to make sure the directory stays warning-free.
|
Assignee | |
Comment 1•8 years ago
|
||
Naive attempt here: https://tbpl.mozilla.org/?tree=Try&rev=b7bc387be59b
|
|
Assignee | |
Comment 2•8 years ago
|
||
All builds are okay except on MacOS. Hopefully that one will be green: https://tbpl.mozilla.org/?tree=Try&rev=649ecfa1f675 (it is including the two smslib fixes)
|
|
Assignee | |
Comment 3•8 years ago
|
||
This is passing try.
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #640997 -
Flags: review?(justin.lebar+bug)
|
||
Updated•8 years ago
|
Attachment #640997 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Updated•8 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla16
|
||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/322ef042e1d2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•