Last Comment Bug 772373 - Make hal/ warning free
: Make hal/ warning free
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Hardware Abstraction Layer (HAL) (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mounir Lamouri (:mounir)
:
:
Mentors:
Depends on: 772351 772524
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-10 02:41 PDT by Mounir Lamouri (:mounir)
Modified: 2012-07-13 05:32 PDT (History)
1 user (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.58 KB, patch)
2012-07-11 03:48 PDT, Mounir Lamouri (:mounir)
justin.lebar+bug: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2012-07-10 02:41:49 PDT
We should add FAIL_ON_WARNINGS = 1 to hal/Makefile.in to make sure the directory stays warning-free.
Comment 1 Mounir Lamouri (:mounir) 2012-07-10 03:55:20 PDT
Naive attempt here: https://tbpl.mozilla.org/?tree=Try&rev=b7bc387be59b
Comment 2 Mounir Lamouri (:mounir) 2012-07-10 10:00:45 PDT
All builds are okay except on MacOS. Hopefully that one will be green:
https://tbpl.mozilla.org/?tree=Try&rev=649ecfa1f675 (it is including the two smslib fixes)
Comment 3 Mounir Lamouri (:mounir) 2012-07-11 03:48:23 PDT
Created attachment 640997 [details] [diff] [review]
Patch

This is passing try.
Comment 4 Ed Morley [:emorley] 2012-07-13 05:32:33 PDT
https://hg.mozilla.org/mozilla-central/rev/322ef042e1d2

Note You need to log in before you can comment on or make changes to this bug.