The default bug view has changed. See this FAQ.

Fix "data argument not used by format string" warnings in smslib.mm

RESOLVED FIXED in mozilla16

Status

()

Core
Hardware Abstraction Layer (HAL)
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: reuben, Assigned: reuben)

Tracking

Trunk
mozilla16
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 640646 [details] [diff] [review]
Fix unused format strings with unused data arguments
Attachment #640646 - Flags: review?(mounir)
Comment on attachment 640646 [details] [diff] [review]
Fix unused format strings with unused data arguments

Review of attachment 640646 [details] [diff] [review]:
-----------------------------------------------------------------

::: hal/cocoa/smslib.mm
@@ +416,5 @@
>  				failure_result = SMS_FAIL_OPENING;
>  			}
>  			continue;
>  		} else if (connection == 0) {
> +			LOG_ARG(@"'success', but didn't get a connection. return value 0x%x.\n", result);

Could you put that between parenthesis like: "[...] didn't get a connection (return value was: 0x%x).\n"?
Attachment #640646 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 640685 [details] [diff] [review]
Fix unused format strings with unused data arguments

Sure. Carrying r=mounir.
Attachment #640646 - Attachment is obsolete: true
Attachment #640685 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe989a36789a
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fe989a36789a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.