Last Comment Bug 772524 - Fix "data argument not used by format string" warnings in smslib.mm
: Fix "data argument not used by format string" warnings in smslib.mm
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Hardware Abstraction Layer (HAL) (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Reuben Morais [:reuben]
:
Mentors:
Depends on:
Blocks: 772373
  Show dependency treegraph
 
Reported: 2012-07-10 09:53 PDT by Reuben Morais [:reuben]
Modified: 2012-07-10 20:31 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix unused format strings with unused data arguments (1.52 KB, patch)
2012-07-10 09:53 PDT, Reuben Morais [:reuben]
mounir: review+
Details | Diff | Splinter Review
Fix unused format strings with unused data arguments (1.53 KB, patch)
2012-07-10 11:00 PDT, Reuben Morais [:reuben]
reuben.bmo: review+
Details | Diff | Splinter Review

Description Reuben Morais [:reuben] 2012-07-10 09:53:58 PDT
Created attachment 640646 [details] [diff] [review]
Fix unused format strings with unused data arguments
Comment 1 Mounir Lamouri (:mounir) 2012-07-10 09:58:23 PDT
Comment on attachment 640646 [details] [diff] [review]
Fix unused format strings with unused data arguments

Review of attachment 640646 [details] [diff] [review]:
-----------------------------------------------------------------

::: hal/cocoa/smslib.mm
@@ +416,5 @@
>  				failure_result = SMS_FAIL_OPENING;
>  			}
>  			continue;
>  		} else if (connection == 0) {
> +			LOG_ARG(@"'success', but didn't get a connection. return value 0x%x.\n", result);

Could you put that between parenthesis like: "[...] didn't get a connection (return value was: 0x%x).\n"?
Comment 2 Reuben Morais [:reuben] 2012-07-10 11:00:59 PDT
Created attachment 640685 [details] [diff] [review]
Fix unused format strings with unused data arguments

Sure. Carrying r=mounir.
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-10 15:37:26 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe989a36789a
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-10 20:31:04 PDT
https://hg.mozilla.org/mozilla-central/rev/fe989a36789a

Note You need to log in before you can comment on or make changes to this bug.