If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

ReferenceError: reference to undefined property aViewport.width since bug #758620

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cwiiis, Assigned: cwiiis)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Attachment 636359 [details] [diff] uses aViewport.width/aViewport.height in setViewport, neither of which actually exist (sorry) - as it turns out, the function they call with these values still does something sensible (hurray), but instead, we should use the right values. This seems to have no obvious ill effect, other than an annoying message in the log.

Patch incoming.
(Assignee)

Comment 1

5 years ago
Created attachment 640642 [details] [diff] [review]
Don't use properties that don't exist

Calculate the viewport width/height first and use those variables in both places it's expected.
Attachment #640642 - Flags: review?(bugmail.mozilla)
Attachment #640642 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 2

5 years ago
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/f5ba1d1f6f0e
https://hg.mozilla.org/mozilla-central/rev/f5ba1d1f6f0e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.