772577 - Build failure: error C2065: 'L' : undeclared identifier @ GLLibraryEGL.cpp(105)

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[Honza Bambas (:mayhemer)]

Win 7, VC10, pymake.

.mozconfig

# Options for client.mk.
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/_obj-browser-debug
mk_add_options MOZ_MAKE_FLAGS=-j9

# Options for 'configure' (same as command-line options).
#ac_add_options --enable-jemalloc

export MOZ_DEBUG_SYMBOLS=1

ac_add_options --enable-application=browser
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --enable-shared
ac_add_options --disable-static
ac_add_options --enable-tests
ac_add_options --enable-logging
ac_add_options --enable-visual-event-tracer
ac_add_options --disable-installer
ac_add_options --enable-chrome-format=flat
ac_add_options --disable-crashreporter
ac_add_options --disable-webm
ac_add_options --disable-accessibility
ac_add_options --disable-angle

ac_add_options --disable-webrtc


c:\Mozilla\src\mozilla-central\config\rules.mk:1031:0$ c:/Mozilla/src/mozilla-central/_obj-browser-debug/_virtualenv/Scripts/python.exe -O c:/Mozilla/src/mozi
lla-central/build/cl.py cl -FoGLLibraryEGL.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DMOZ_D3DX9_DLL= -DMOZ_D3DCOMPILER_DLL= -DMOZILLA_INTERNAL_AP
I -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -Ic:/Mozilla/src/mozilla-centr
al/gfx/gl -I. -I../../dist/include  -Ic:/Mozilla/src/mozilla-central/_obj-browser-debug/dist/include/nspr -Ic:/Mozilla/src/mozilla-central/_obj-browser-debug/
dist/include/nss        -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4800 -we4553 -GR-  -DDEBUG -D_DEBUG -DTRACING -Zi -Oy-  -Ic:/Mozilla/src/mozilla-central/_obj-
browser-debug/dist/include/cairo   -MDd           -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.
cpp
GLLibraryEGL.cpp
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(105) : warning C4003: not enough actual parameters for macro 'NS_STRINGIFY_HELPER'
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(105) : warning C4003: not enough actual parameters for macro 'NS_LL'
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(105) : error C2065: 'L' : undeclared identifier
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(105) : error C2065: 'L' : undeclared identifier
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(105) : error C2070: ''unknown-type'': illegal sizeof operand
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(111) : warning C4003: not enough actual parameters for macro 'NS_STRINGIFY_HELPER'
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(111) : warning C4003: not enough actual parameters for macro 'NS_LL'
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(111) : error C2065: 'L' : undeclared identifier
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(111) : error C2065: 'L' : undeclared identifier
c:/Mozilla/src/mozilla-central/gfx/gl/GLLibraryEGL.cpp(111) : error C2070: ''unknown-type'': illegal sizeof operand

Comment 1

[Honza Bambas (:mayhemer)]

--disable-webgl doesn't change anything.

My tree is now broken and there is no workaround except updating back at time.  This bug prevents me from working.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to Honza Bambas (:mayhemer) from comment #1)
> --disable-webgl doesn't change anything.
> 
> My tree is now broken and there is no workaround except updating back at
> time.  This bug prevents me from working.

Wait, are you saying that just unapplying my changeset doesn't fix it?

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

What if you edit config/autoconf.mk and remove the line that defines MOZ_WEBGL ?

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to Benoit Jacob [:bjacob] from comment #2)
> (In reply to Honza Bambas (:mayhemer) from comment #1)
> > --disable-webgl doesn't change anything.
> > 
> > My tree is now broken and there is no workaround except updating back at
> > time.  This bug prevents me from working.
> 
> Wait, are you saying that just unapplying my changeset doesn't fix it?

No, I say that adding --disable-webgl option to my .mozconfig doesn't help.  I'm now building from http://hg.mozilla.org/mozilla-central/rev/002efc873e32 that should be the last working for me.  I'll report in few minutes.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

I'm saying, you identified correctly the bug that regressed it, you could simply reverse the patch from that bug and continue working normally, instead of staying on the last revision before that cset.

Also, please try out comment 3.

Comment 6

[Honza Bambas (:mayhemer)]

Backing out http://hg.mozilla.org/mozilla-central/raw-rev/2e6bc1480efd helps.


Following change:
diff --git a/config/autoconf.mk.in b/config/autoconf.mk.in
--- a/config/autoconf.mk.in
+++ b/config/autoconf.mk.in
@@ -155,17 +155,16 @@ LIBJPEG_TURBO_ARM_ASM = @LIBJPEG_TURBO_A
 NS_PRINTING = @NS_PRINTING@
 MOZ_PDF_PRINTING = @MOZ_PDF_PRINTING@
 MOZ_CRASHREPORTER = @MOZ_CRASHREPORTER@
 MOZ_CRASHREPORTER_INJECTOR = @MOZ_CRASHREPORTER_INJECTOR@
 MOZ_HELP_VIEWER = @MOZ_HELP_VIEWER@
 MOC = @MOC@
 RCC = @RCC@
 MOZ_NSS_PATCH = @MOZ_NSS_PATCH@
-MOZ_WEBGL = @MOZ_WEBGL@
 MOZ_ANGLE = @MOZ_ANGLE@

doesn't help.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

OK, so if you apply BOTH the "fix the --disable-webgl build" patch from bug 760323 AND the patch from bug 772457, then --disable-webgl should be working correctly and allow you to build without errors, without the DXSDK. Please try (works here).