772633 - Search for the command line arg 'metrodesktop' across all command line parameters

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jim Mathies [:jimm]]

Attachment: patch

This will be handy in getting tests running using the metrodesktop command line arg. The test harness adds a number of params before it appends user set args when launching the browser.

Comment 1

[Brian R. Bondy [:bbondy]]

Comment on attachment 640765 [details] [diff] [review]
patch

Review of attachment 640765 [details] [diff] [review]:
-----------------------------------------------------------------

I noticed this bug before too and meant to post a task for it, thanks!

::: browser/app/nsBrowserApp.cpp
@@ +187,5 @@
> +    } else {
> +      // This command-line flag is used to test the metro browser in a desktop
> +      // environment.
> +      for (int idx = 1; idx < argc; idx++) {
> +        if (IsParameterArg(argv[idx]) && IsArg(argv[idx], "metrodesktop")) {

Couldn't we just call IsArg and scrap the call to IsParameterArg?
IsArg returns false if the string doesn't start with - or /

Comment 2

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #1)
> Couldn't we just call IsArg and scrap the call to IsParameterArg?
> IsArg returns false if the string doesn't start with - or /

ah yes IsParameterArg is totally redundant. I'll update.

Comment 3

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/e3f69b867e6e

Comment 4

[Brian R. Bondy [:bbondy]]

Looks good, thanks for the update

Comment 5

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.