772776 - add a "visibility group" for the partner-confidential group

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, enhancement)

Description

[:glob ✱]

the partner-confidential group was created for CC-only visibility of groups (ie. the group will have no real members).

the problem with this configuration is the group will not be visible on enter_bug or show_bug, so it's impossible to place bugs into that group.


as a stop gap i've reconfigured the group from shown/na to shown/shown on the boot2gecko to allow b2g partners to start using it.

the problem with this scenario is it's visible to everyone, and due to the highly restrictive visibility of bugs in this group, bugs may get "lost" -- no-one will get notified of a bug if the reporter doesn't CC anyone, or the correct people.


we should add partner-confidential-visible (or similar) group, and display the partner-confidential group to members of that group.


we also need to sort out notifications.  one idea is to have a per-product list of auto-cc's for bugs filed into the partner-confidential group.

Comment 1

[:glob ✱]

Attachment: patch v1

this patch adds a partner-confidential checkbox to enter_bug for members of the partner-confidential-visible, and allows us to CC users to bugs at creation time based on the bug's groups and product.

i've renamed %group_to_cc_map to %group_change_notification to avoid confusion with the new group cc function.

the new checkbox won't be visible on the guided bug entry; i don't think it belongs there.

the group is only visible at bug creation time, not on show_bug.

in this revision the :mbest will be automatically CC'd to all partner-confidential bugs in the boot2gecko product.  this probably isn't right, but i'd like to get eyes on this patch.

Comment 2

[Martin Best (:mbest)]

I don't need to see everything coming out of B2G but I'm also happy to be added to the list in the short term and see if I just get a lot of noise.  We use this group primarily for bugs relating to code bases that partners have given us to test against for games.  We haven't needed it extensively yet, but that is likely to change over the next two quarters.  We will have to be very careful who is allowed into the group by default.  The nice thing about the CC approach purely as that we know exactly who sees the information.  The group adds some risk, so as long as the box is unchecked by default we should be ok on our end.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 641103 [details] [diff] [review]
patch v1

Review of attachment 641103 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine and works as expected. r=dkl

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
modified extensions/BMO/template/en/default/hook/bug/create/create-form.html.tmpl
Committed revision 8252.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/BMO/Extension.pm
modified extensions/BMO/lib/Data.pm
modified extensions/BMO/template/en/default/hook/bug/create/create-form.html.tmpl
Committed revision 8262.