77287 - investigate removing HTMLDocumentColorRule

Status: RESOLVED DUPLICATE of bug 655549

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I should investigate whether we need the HTMLDocumentColorRule anymore (in
nsHTMLStyleSheet.cpp).  It might be obsolete now that BodyFixupRule exists.  See
the discussion in bug 70831.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

From bug 70831:

------- Additional Comments From David Baron 2001-04-24 09:57 -------

OK -- I made the change that you suggested.

I think the real fix is to split up the 3 uses for HTMLDocumentStyleColor:
 1) We use it to implement document.fgColor and document.fgColor in HTML
documents when we have no body element (i.e, if the script is running before the
body element is created).  (This issue is messy -- I'm also wondering if the
code in the body element itself needs some fixing too, but that's another issue...)

 2) We use it to match the HTML element in the attribute stylesheet
(nsHTMLStyleSheet).  I think this predates the BodyFixupRule and can be removed
(and it may mess up user stylesheets in some cases).

 3) We use it to apply to inner table contents in quirks mode.  We should
reexamine whether this is really the best way to handle this, but if it is, then
perhaps the HTMLDocumentColorRule could be only for this and (1) could be
handled by something else (or vice versa, although I think the solution in (1)
probably doesn't get along with the BodyFixupRule).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Wolud this fix bug 47760?

Comment 3

[Boris Zbarsky [:bzbarsky]]

So use #1 seems to no longer exist (assuming this is the nsHTMLColorRule we're
talking about).  There is also no more body fixup rule....

Comment 4

[Bernd]

It seems that  HTMLDocumentColorRule was removed within bug 94688.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And mDocumentColorRule was removed in 
https://hg.mozilla.org/mozilla-central/rev/9439ffe089a1