773003 - Validator needs a Spidermonkey upgrade

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Kris Maglione [:kmag]]

Current versions of Firefox support a newer version of JS than the validator, including for-of loops. The validator needs to be updated to support these. At the least, they need to not generate a compile-time error.

Comment 1

[Matt Basta [:basta]]

This has to happen in two parts:

The first part is physically upgrading Spidermonkey, which presumably needs to be handled by IT.
The second part is adding mechanisms to the validator to recognize the new ES constructs.

The first part will make the errors go away. The second part will allow the validator to interpret the new constructs and perform analysis on them.

Wil: can you talk to IT about getting this in motion or find out what direction we should go in for this?

Comment 2

[Kris Maglione [:kmag]]

The Spidermonkey upgrade doesn't seem to have helped. We're still getting syntax errors for for-of statements on prod: https://addons.mozilla.org/en-US/firefox/files/browse/159639/file/chrome/jsterm.js#L249

Maybe the version they upgraded to is not new enough?

Comment 3

[Matt Basta [:basta]]

It's likely that the standalone version of Spidermonkey doesn't yet support the same constructs that Firefox supports.

Comment 4

[Kris Maglione [:kmag]]

If it's built from mozilla-central, it should. We also might need to add a version flag. The required arguments seem to change more or less at random between Spidermonkey releases, so I'm not sure either way.

Comment 5

[Kris Maglione [:kmag]]

Bumping priority. for-of has been showing up in a lot of add-ons lately, and any files that use it don't get validated.

Comment 6

[Matt Basta [:basta]]

Should fix the E4X tracebacks:

https://github.com/mozilla/amo-validator/commit/f3b588eb997b67c8e972a0d2f2f271c9596f166d