Closed
Bug 773039
Opened 12 years ago
Closed 12 years ago
Talkback announces all items in menu when menu is shown
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 fixed)
RESOLVED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file)
1.30 KB,
patch
|
blassey
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This is confusing and chatty for blind users. This does not happen in other apps.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → eitan
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 15
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to David Bolter [:davidb] from comment #2) > Eitan how does this fix work? (Just curious) The default implementation of dispatchPopulateAccessibilityEvent calls dispatchPopulateAccessibilityEvent of all the child views, and each view appends text to the event. The override here does not go in to child views.
Comment 5•12 years ago
|
||
Comment on attachment 641207 [details] [diff] [review] Don't populate menu accessibility event with descendant strings. Review of attachment 641207 [details] [diff] [review]: ----------------------------------------------------------------- Eitan, I'd be a little worried about the side effects of this change, but I suspect they'd all be related to accessibility and trust that you'll work through what ever crops up.
Attachment #641207 -
Flags: review?(blassey.bugs) → review+
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Brad Lassey [:blassey] from comment #5) > Comment on attachment 641207 [details] [diff] [review] > Don't populate menu accessibility event with descendant strings. > > Review of attachment 641207 [details] [diff] [review]: > ----------------------------------------------------------------- > > Eitan, I'd be a little worried about the side effects of this change, but I > suspect they'd all be related to accessibility and trust that you'll work > through what ever crops up. First, yes. This is a code path that is only reached when accessibility is on. Second, it is relatively well documented here: http://developer.android.com/guide/topics/ui/accessibility/apps.html#populate-events
Assignee | ||
Comment 7•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/6a5d9afb58e5
Updated•12 years ago
|
Target Milestone: Firefox 15 → Firefox 16
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6a5d9afb58e5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 9•12 years ago
|
||
Comment on attachment 641207 [details] [diff] [review] Don't populate menu accessibility event with descendant strings. [Approval Request Comment] Bug caused by (feature/regressing bug #): default widget implementation User impact if declined: Whenever a TalkBack user opens the menu, the whole menu items get read to them. Makes working very hard because one does not know which item actually has the focus. Testing completed (on m-c, etc.): Yes, on a local build. Risk to taking this patch (and alternatives if risky): None that we can see. String or UUID changes made by this patch: None.
Attachment #641207 -
Flags: approval-mozilla-aurora?
Comment 10•12 years ago
|
||
Comment on attachment 641207 [details] [diff] [review] Don't populate menu accessibility event with descendant strings. [Triage Comment] Approved for FF15 given that the a11y reward outweighs the near-zero risk to a non-a11y user.
Attachment #641207 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-aurora/rev/71e4b3b43ec9
status-firefox15:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•