Talkback announces all items in menu when menu is shown

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is confusing and chatty for blind users. This does not happen in other apps.
(Assignee)

Updated

5 years ago
Assignee: nobody → eitan
(Assignee)

Comment 1

5 years ago
Created attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.
Attachment #641207 - Flags: review?(blassey.bugs)
(Assignee)

Updated

5 years ago
Target Milestone: --- → Firefox 15
Eitan how does this fix work? (Just curious)
(Assignee)

Comment 3

5 years ago
(In reply to David Bolter [:davidb] from comment #2)
> Eitan how does this fix work? (Just curious)

The default implementation of dispatchPopulateAccessibilityEvent calls dispatchPopulateAccessibilityEvent of all the child views, and each view appends text to the event. The override here does not go in to child views.
Bingo. Thanks!
Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

Review of attachment 641207 [details] [diff] [review]:
-----------------------------------------------------------------

Eitan, I'd be a little worried about the side effects of this change, but I suspect they'd all be related to accessibility and trust that you'll work through what ever crops up.
Attachment #641207 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 6

5 years ago
(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 641207 [details] [diff] [review]
> Don't populate menu accessibility event with descendant strings.
> 
> Review of attachment 641207 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Eitan, I'd be a little worried about the side effects of this change, but I
> suspect they'd all be related to accessibility and trust that you'll work
> through what ever crops up.

First, yes. This is a code path that is only reached when accessibility is on. Second, it is relatively well documented here:
http://developer.android.com/guide/topics/ui/accessibility/apps.html#populate-events
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/6a5d9afb58e5

Updated

5 years ago
Target Milestone: Firefox 15 → Firefox 16

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/6a5d9afb58e5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 9

5 years ago
Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): default widget implementation
User impact if declined: Whenever a TalkBack user opens the menu, the whole menu items get read to them. Makes working very hard because one does not know which item actually has the focus.
Testing completed (on m-c, etc.): Yes, on a local build.
Risk to taking this patch (and alternatives if risky): None that we can see.
String or UUID changes made by this patch: None.
Attachment #641207 - Flags: approval-mozilla-aurora?
Comment on attachment 641207 [details] [diff] [review]
Don't populate menu accessibility event with descendant strings.

[Triage Comment]
Approved for FF15 given that the a11y reward outweighs the near-zero risk to a non-a11y user.
Attachment #641207 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/71e4b3b43ec9
status-firefox15: --- → fixed

Updated

5 years ago
Depends on: 773952
You need to log in before you can comment on or make changes to this bug.