Last Comment Bug 773102 - transition-duration and animation-duration should reject negative values at parse time
: transition-duration and animation-duration should reject negative values at p...
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: CSS Parsing and Computation (show other bugs)
: Trunk
: All All
: P3 normal (vote)
: mozilla16
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-11 17:15 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2012-08-02 22:29 PDT (History)
4 users (show)
dbaron: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Require animation-duration and transtion-duration to be nonnegative at parse time. (, patch 3) (3.72 KB, patch)
2012-07-11 17:18 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Splinter Review
Rename VARIANT_POSITIVE_LENGTH to VARIANT_NONNEGATIVE_DIMENSION since (a) it also applies to times and frequencies and (b) it allows 0. (patch 1) (3.98 KB, patch)
2012-07-11 17:18 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review-
Details | Diff | Splinter Review
Rename VARIANT_POSITIVE_LENGTH to VARIANT_POSITIVE_DIMENSION since it also applies to times and frequencies. (, patch 1) (3.97 KB, patch)
2012-07-13 12:05 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Splinter Review
Add VARIANT_NONNEGATIVE_DIMENSION. (, patch 2) (2.31 KB, patch)
2012-07-13 12:05 PDT, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
bzbarsky: review+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-11 17:15:10 PDT
Per resolution in the CSS working group's teleconference today, animation-duration and transition-duration should reject negative values at parse time.
http://lists.w3.org/Archives/Public/www-style/2012Jul/0265.html
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-11 17:18:01 PDT
Created attachment 641274 [details] [diff] [review]
Require animation-duration and transtion-duration to be nonnegative at parse time.  (, patch 3)
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-11 17:18:57 PDT
Created attachment 641275 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_NONNEGATIVE_DIMENSION since (a) it also applies to times and frequencies and (b) it allows 0.  (patch 1)
Comment 3 Boris Zbarsky [:bz] 2012-07-12 20:36:33 PDT
Comment on attachment 641275 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_NONNEGATIVE_DIMENSION since (a) it also applies to times and frequencies and (b) it allows 0.  (patch 1)

The parser code ungets and returns false if "tk->mNumber <= 0.0".  So as far as I can tell, it really is requiring a positive value....

And in fact, the spec for "perspective" claims that lengths "must be positive".  Or is the spec and the parser code wrong?
Comment 4 Boris Zbarsky [:bz] 2012-07-12 20:37:14 PDT
Comment on attachment 641274 [details] [diff] [review]
Require animation-duration and transtion-duration to be nonnegative at parse time.  (, patch 3)

This seems fine, assuming the first patch is fine...
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-13 12:05:41 PDT
Created attachment 641988 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_POSITIVE_DIMENSION since it also applies to times and frequencies.  (, patch 1)
Comment 6 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-13 12:05:53 PDT
Created attachment 641989 [details] [diff] [review]
Add VARIANT_NONNEGATIVE_DIMENSION.  (, patch 2)
Comment 7 Boris Zbarsky [:bz] 2012-07-13 12:29:32 PDT
Comment on attachment 641988 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_POSITIVE_DIMENSION since it also applies to times and frequencies.  (, patch 1)

r=me
Comment 8 Boris Zbarsky [:bz] 2012-07-13 12:30:13 PDT
Comment on attachment 641989 [details] [diff] [review]
Add VARIANT_NONNEGATIVE_DIMENSION.  (, patch 2)

r=me
Comment 12 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-07-13 18:06:12 PDT
The difference from the last landing is:

https://hg.mozilla.org/integration/mozilla-inbound/diff/1e6065596ace/layout/style/test/test_transitions_computed_value_combinations.html

Note You need to log in before you can comment on or make changes to this bug.