773102 - transition-duration and animation-duration should reject negative values at parse time

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Per resolution in the CSS working group's teleconference today, animation-duration and transition-duration should reject negative values at parse time.
http://lists.w3.org/Archives/Public/www-style/2012Jul/0265.html

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Require animation-duration and transtion-duration to be nonnegative at parse time. (, patch 3)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Rename VARIANT_POSITIVE_LENGTH to VARIANT_NONNEGATIVE_DIMENSION since (a) it also applies to times and frequencies and (b) it allows 0. (patch 1)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 641275 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_NONNEGATIVE_DIMENSION since (a) it also applies to times and frequencies and (b) it allows 0.  (patch 1)

The parser code ungets and returns false if "tk->mNumber <= 0.0".  So as far as I can tell, it really is requiring a positive value....

And in fact, the spec for "perspective" claims that lengths "must be positive".  Or is the spec and the parser code wrong?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 641274 [details] [diff] [review]
Require animation-duration and transtion-duration to be nonnegative at parse time.  (, patch 3)

This seems fine, assuming the first patch is fine...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Rename VARIANT_POSITIVE_LENGTH to VARIANT_POSITIVE_DIMENSION since it also applies to times and frequencies. (, patch 1)

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Add VARIANT_NONNEGATIVE_DIMENSION. (, patch 2)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 641988 [details] [diff] [review]
Rename VARIANT_POSITIVE_LENGTH to VARIANT_POSITIVE_DIMENSION since it also applies to times and frequencies.  (, patch 1)

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 641989 [details] [diff] [review]
Add VARIANT_NONNEGATIVE_DIMENSION.  (, patch 2)

r=me

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1480ab5116
https://hg.mozilla.org/integration/mozilla-inbound/rev/576f7d52de4b
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a030d4733a0

Comment 10

[(no longer active)]

Backed out because of test failure: https://hg.mozilla.org/integration/mozilla-inbound/rev/16b2a1339ec0

Sample failure log: https://tbpl.mozilla.org/php/getParsedLog.php?id=13509570&tree=Mozilla-Inbound&full=1

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d29e87c3b64
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f2ab38fd992
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e6065596ace

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The difference from the last landing is:

https://hg.mozilla.org/integration/mozilla-inbound/diff/1e6065596ace/layout/style/test/test_transitions_computed_value_combinations.html

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d29e87c3b64
https://hg.mozilla.org/mozilla-central/rev/6f2ab38fd992
https://hg.mozilla.org/mozilla-central/rev/1e6065596ace

Comment 14

[Jean-Yves Perrier [:teoli]]

I've added a sentence in:
https://developer-new.mozilla.org/en-US/docs/CSS/transition-duration
https://developer-new.mozilla.org/en-US/docs/CSS/animation-duration
(Negative values are invalid)

and added the info in 
https://developer-new.mozilla.org/en-US/docs/Firefox_16_for_developers