1363592 - stylo: {transition, animation}-duration should reject negative values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Jeremy Chen ([e-mail])]

Currently, {transition, animation}-duration and {transition, animation}-delay share the same parsing codes, which accept all <time> units values w/o restrictions. However, according to the spec, negative time values are invalid for {transition, animation}-duration properties.

Since fixing this could fix ~20 mochitests failures, let's do this.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://github.com/servo/servo/issues/15343

Comment 2

[Hiroyuki Ikezoe (:hiro)]

A contributor is working on this;
https://github.com/servo/servo/pull/15658

Comment 3

[Jeremy Chen ([e-mail])]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> A contributor is working on this;
> https://github.com/servo/servo/pull/15658

Well, then I shall leave this bug open, and consider resolve this bug once the PR get landed.

Thank you for the notice. :)

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I did open a new PR:
https://github.com/servo/servo/pull/16829

Comment 5

[Jeremy Chen ([e-mail])]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)
> I did open a new PR:
> https://github.com/servo/servo/pull/16829

Okay, I guess I shall forward this bug to you then.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1363592 - Update mochitest expectations for transition and animation duration.

Review commit: https://reviewboard.mozilla.org/r/138704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138704/

Comment 7

[Jeremy Chen ([e-mail])]

Comment on attachment 8867103 [details]
Bug 1363592 - Update mochitest expectations for transition and animation duration.

https://reviewboard.mozilla.org/r/138704/#review142000

LGTM! Thank you for taking over this. :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6811713d47c
Update mochitest expectations for transition and animation duration. r=jeremychen

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a6811713d47c