Should unify the mock for Windows Registry in mailnews/import/unit/test/.

RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Testing Infrastructure
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
Thunderbird 17.0
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 641311 [details] [diff] [review]
Fix

test_oe_settings.js has its own mock of nsIWindowsRegKey, it should use the mock in resouces/mock_windows_reg_factory.js.

test_winmail.js has also its own mock, I will fix it in bug 772712.
Attachment #641311 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Blocks: 773127
(Assignee)

Updated

5 years ago
Blocks: 772712
Comment on attachment 641311 [details] [diff] [review]
Fix

Review of attachment 641311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good - just one suggestion. Thanks hiro!

::: mailnews/import/test/unit/resources/mock_windows_reg_factory.js
@@ +81,5 @@
> +
> +function setup_mock_registry(mockRegistry) {
> +  gUuid = Cc["@mozilla.org/uuid-generator;1"]
> +            .getService(Ci.nsIUUIDGenerator)
> +            .generateUUID().toString();

Let's continue the pattern, and put .toString(); on the next line.
Attachment #641311 - Flags: review?(mconley) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 643694 [details] [diff] [review]
Addressed review comment

Thank you for reviewing!
Attachment #641311 - Attachment is obsolete: true
Attachment #643694 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8ea8efbb5515
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.