Last Comment Bug 773124 - Should unify the mock for Windows Registry in mailnews/import/unit/test/.
: Should unify the mock for Windows Registry in mailnews/import/unit/test/.
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Testing Infrastructure (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Hiroyuki Ikezoe (:hiro)
:
:
Mentors:
Depends on:
Blocks: 772712 773127
  Show dependency treegraph
 
Reported: 2012-07-11 19:05 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2012-07-18 18:26 PDT (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix (9.57 KB, patch)
2012-07-11 19:05 PDT, Hiroyuki Ikezoe (:hiro)
mconley: review+
Details | Diff | Splinter Review
Addressed review comment (9.58 KB, patch)
2012-07-18 17:46 PDT, Hiroyuki Ikezoe (:hiro)
hiikezoe: review+
Details | Diff | Splinter Review

Description Hiroyuki Ikezoe (:hiro) 2012-07-11 19:05:18 PDT
Created attachment 641311 [details] [diff] [review]
Fix

test_oe_settings.js has its own mock of nsIWindowsRegKey, it should use the mock in resouces/mock_windows_reg_factory.js.

test_winmail.js has also its own mock, I will fix it in bug 772712.
Comment 1 Mike Conley (:mconley) 2012-07-18 12:27:52 PDT
Comment on attachment 641311 [details] [diff] [review]
Fix

Review of attachment 641311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good - just one suggestion. Thanks hiro!

::: mailnews/import/test/unit/resources/mock_windows_reg_factory.js
@@ +81,5 @@
> +
> +function setup_mock_registry(mockRegistry) {
> +  gUuid = Cc["@mozilla.org/uuid-generator;1"]
> +            .getService(Ci.nsIUUIDGenerator)
> +            .generateUUID().toString();

Let's continue the pattern, and put .toString(); on the next line.
Comment 2 Hiroyuki Ikezoe (:hiro) 2012-07-18 17:46:12 PDT
Created attachment 643694 [details] [diff] [review]
Addressed review comment

Thank you for reviewing!
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-18 18:26:37 PDT
https://hg.mozilla.org/comm-central/rev/8ea8efbb5515

Note You need to log in before you can comment on or make changes to this bug.