Closed Bug 773124 Opened 10 years ago Closed 10 years ago

Should unify the mock for Windows Registry in mailnews/import/unit/test/.

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix (obsolete) — Splinter Review
test_oe_settings.js has its own mock of nsIWindowsRegKey, it should use the mock in resouces/mock_windows_reg_factory.js.

test_winmail.js has also its own mock, I will fix it in bug 772712.
Attachment #641311 - Flags: review?(mconley)
Blocks: 773127
Blocks: 772712
Comment on attachment 641311 [details] [diff] [review]
Fix

Review of attachment 641311 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good - just one suggestion. Thanks hiro!

::: mailnews/import/test/unit/resources/mock_windows_reg_factory.js
@@ +81,5 @@
> +
> +function setup_mock_registry(mockRegistry) {
> +  gUuid = Cc["@mozilla.org/uuid-generator;1"]
> +            .getService(Ci.nsIUUIDGenerator)
> +            .generateUUID().toString();

Let's continue the pattern, and put .toString(); on the next line.
Attachment #641311 - Flags: review?(mconley) → review+
Thank you for reviewing!
Attachment #641311 - Attachment is obsolete: true
Attachment #643694 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8ea8efbb5515
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.