Last Comment Bug 772712 - Get back the test for Windows Live Mail settings importer
: Get back the test for Windows Live Mail settings importer
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Import (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
Depends on: 773124 773127 773145
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-10 18:08 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2012-08-13 18:22 PDT (History)
4 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed fix (17.45 KB, patch)
2012-07-11 21:25 PDT, Hiroyuki Ikezoe (:hiro)
no flags Details | Diff | Review
Fix (17.96 KB, patch)
2012-07-11 21:40 PDT, Hiroyuki Ikezoe (:hiro)
mconley: review+
Details | Diff | Review

Description Hiroyuki Ikezoe (:hiro) 2012-07-10 18:08:44 PDT
mailnews/import/test/unit/test_winmail.js is now disabled but we need it.
Comment 1 Hiroyuki Ikezoe (:hiro) 2012-07-11 21:25:04 PDT
Created attachment 641346 [details] [diff] [review]
Proposed fix

This patch needs both the fixes for bug 773127 and 773124.
Comment 2 Hiroyuki Ikezoe (:hiro) 2012-07-11 21:31:31 PDT
Unfortunately the test fails on the current trunk because the return value of GetValueForTag is not checked.

For example:

http://mxr.mozilla.org/comm-central/source/mailnews/import/winlivemail/nsWMSettings.cpp#500

500       GetValueForTag(xmlDoc, NS_LITERAL_STRING("Leave_Mail_On_Server"), value);
501       if (!value.IsEmpty())
502         pop3Server->SetLeaveMessagesOnServer((bool)value.ToInteger(&errorCode, 16));
503       GetValueForTag(xmlDoc, NS_LITERAL_STRING("Remove_When_Deleted"), value);
504       if (!value.IsEmpty())
505         pop3Server->SetDeleteMailLeftOnServer((bool)value.ToInteger(&errorCode, 16));

the value of "Remove_When_Deleted" is the previous one, i.e. "Leave_Mail_On_Server", if "Remove_When_Deleted" does not exist in registry data.

I will open a new bug for this issue.
Comment 3 Hiroyuki Ikezoe (:hiro) 2012-07-11 21:40:29 PDT
Created attachment 641350 [details] [diff] [review]
Fix

I forgot including the diff of xpcshell.ini.
Comment 4 Mike Conley (:mconley) - (Away until June 29th) 2012-07-18 12:34:22 PDT
I'll wait for bug 773145 to land before reviewing this.
Comment 5 Mike Conley (:mconley) - (Away until June 29th) 2012-08-13 07:07:33 PDT
Comment on attachment 641350 [details] [diff] [review]
Fix

Sorry it took me so long to get to this!

This looks good. Thanks Hiro!
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-08-13 18:22:18 PDT
https://hg.mozilla.org/comm-central/rev/286425ebf6a5

Note You need to log in before you can comment on or make changes to this bug.