Closed Bug 772712 Opened 12 years ago Closed 11 years ago
Get back the test for Windows Live Mail settings importer
mailnews/import/test/unit/test_winmail.js is now disabled but we need it.
This patch needs both the fixes for bug 773127 and 773124.
Unfortunately the test fails on the current trunk because the return value of GetValueForTag is not checked. For example: http://mxr.mozilla.org/comm-central/source/mailnews/import/winlivemail/nsWMSettings.cpp#500 500 GetValueForTag(xmlDoc, NS_LITERAL_STRING("Leave_Mail_On_Server"), value); 501 if (!value.IsEmpty()) 502 pop3Server->SetLeaveMessagesOnServer((bool)value.ToInteger(&errorCode, 16)); 503 GetValueForTag(xmlDoc, NS_LITERAL_STRING("Remove_When_Deleted"), value); 504 if (!value.IsEmpty()) 505 pop3Server->SetDeleteMailLeftOnServer((bool)value.ToInteger(&errorCode, 16)); the value of "Remove_When_Deleted" is the previous one, i.e. "Leave_Mail_On_Server", if "Remove_When_Deleted" does not exist in registry data. I will open a new bug for this issue.
I forgot including the diff of xpcshell.ini.
I'll wait for bug 773145 to land before reviewing this.
Comment on attachment 641350 [details] [diff] [review] Fix Sorry it took me so long to get to this! This looks good. Thanks Hiro!
Attachment #641350 - Flags: review?(mconley) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.