Closed
Bug 773145
Opened 13 years ago
Closed 13 years ago
The return value of GetValueForTag should be checked otherwise incorrect data will be imported
Categories
(MailNews Core :: Import, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 17.0
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
35.28 KB,
patch
|
hiro
:
review+
|
Details | Diff | Splinter Review |
As I wrote in bug 772712 comment 2, the return value should be checked.
Attachment #641347 -
Flags: review?(mozilla)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 641347 [details] [diff] [review]
Fix
thx for the patch - it looks ok.
can you move the else to its own line?
+ if (isDirectory) {
+ GetOEAccountFilesInFolder(file, aFileArray);
+ } else {
Attachment #641347 -
Flags: review?(mozilla) → review+
|
||
Comment 2•13 years ago
|
||
Hiro:
Is this ready to check in? I was waiting for it to land to review bug 772712.
-Mike
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
Assignee | |
Comment 4•13 years ago
|
||
mconley, I am sorry I missed that review has been passed.
Now the pacth can be checked in.
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Attachment #641347 -
Attachment is obsolete: true
|
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in
before you can comment on or make changes to this bug.
Description
•