Closed Bug 773145 Opened 11 years ago Closed 11 years ago

The return value of GetValueForTag should be checked otherwise incorrect data will be imported

Categories

(MailNews Core :: Import, defect)

Product:
MailNews Core
Component:
Import
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 17.0

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Fix "else" postion
35.28 KB, patch
hiro
: review+
Details | Diff | Splinter Review
Attached patch Fix (obsolete) — — Splinter Review 
As I wrote in bug 772712 comment 2, the return value should be checked.
Attachment #641347 - Flags: review?(mozilla)
Blocks: 772712
Blocks: 561562
Comment on attachment 641347 [details] [diff] [review]
Fix

thx for the patch - it looks ok.

can you move the else to its own line?

+    if (isDirectory) {
+      GetOEAccountFilesInFolder(file, aFileArray);
+    } else {
Attachment #641347 - Flags: review?(mozilla) → review+
Hiro:

Is this ready to check in? I was waiting for it to land to review bug 772712.

-Mike
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED

        Attachment #645902 -
        Flags: review+

    
    

    
  
mconley, I am sorry I missed that review has been passed.
Now the pacth can be checked in.
Keywords: checkin-needed

        Attachment #641347 -
        Attachment is obsolete: true

    
    

    
  
https://hg.mozilla.org/comm-central/rev/8fcc7b51d0a2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0

          You need to log in
          before you can comment on or make changes to this bug.