The return value of GetValueForTag should be checked otherwise incorrect data will be imported

RESOLVED FIXED in Thunderbird 17.0

Status

MailNews Core
Import
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 17.0
All
Windows XP
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 641347 [details] [diff] [review]
Fix

As I wrote in bug 772712 comment 2, the return value should be checked.
Attachment #641347 - Flags: review?(mozilla)
(Assignee)

Updated

5 years ago
Blocks: 772712
(Assignee)

Updated

5 years ago
Blocks: 561562

Comment 1

5 years ago
Comment on attachment 641347 [details] [diff] [review]
Fix

thx for the patch - it looks ok.

can you move the else to its own line?

+    if (isDirectory) {
+      GetOEAccountFilesInFolder(file, aFileArray);
+    } else {
Attachment #641347 - Flags: review?(mozilla) → review+
Hiro:

Is this ready to check in? I was waiting for it to land to review bug 772712.

-Mike
(Assignee)

Comment 3

5 years ago
Created attachment 645902 [details] [diff] [review]
Fix "else" postion
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Attachment #645902 - Flags: review+
(Assignee)

Comment 4

5 years ago
mconley, I am sorry I missed that review has been passed.
Now the pacth can be checked in.
Keywords: checkin-needed
Attachment #641347 - Attachment is obsolete: true
https://hg.mozilla.org/comm-central/rev/8fcc7b51d0a2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.