Last Comment Bug 773145 - The return value of GetValueForTag should be checked otherwise incorrect data will be imported
: The return value of GetValueForTag should be checked otherwise incorrect dat...
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Import (show other bugs)
: Trunk
: All Windows XP
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Hiroyuki Ikezoe (:hiro)
:
Mentors:
Depends on:
Blocks: 561562 772712
  Show dependency treegraph
 
Reported: 2012-07-11 21:37 PDT by Hiroyuki Ikezoe (:hiro)
Modified: 2012-07-26 17:59 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Fix (35.27 KB, patch)
2012-07-11 21:37 PDT, Hiroyuki Ikezoe (:hiro)
mozilla: review+
Details | Diff | Review
Fix "else" postion (35.28 KB, patch)
2012-07-25 15:20 PDT, Hiroyuki Ikezoe (:hiro)
hiikezoe: review+
Details | Diff | Review

Description Hiroyuki Ikezoe (:hiro) 2012-07-11 21:37:44 PDT
Created attachment 641347 [details] [diff] [review]
Fix

As I wrote in bug 772712 comment 2, the return value should be checked.
Comment 1 David :Bienvenu 2012-07-13 08:10:03 PDT
Comment on attachment 641347 [details] [diff] [review]
Fix

thx for the patch - it looks ok.

can you move the else to its own line?

+    if (isDirectory) {
+      GetOEAccountFilesInFolder(file, aFileArray);
+    } else {
Comment 2 Mike Conley (:mconley) - (Away until June 29th) 2012-07-25 06:57:50 PDT
Hiro:

Is this ready to check in? I was waiting for it to land to review bug 772712.

-Mike
Comment 3 Hiroyuki Ikezoe (:hiro) 2012-07-25 15:20:50 PDT
Created attachment 645902 [details] [diff] [review]
Fix "else" postion
Comment 4 Hiroyuki Ikezoe (:hiro) 2012-07-25 15:22:22 PDT
mconley, I am sorry I missed that review has been passed.
Now the pacth can be checked in.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-26 17:59:12 PDT
https://hg.mozilla.org/comm-central/rev/8fcc7b51d0a2

Note You need to log in before you can comment on or make changes to this bug.