The default bug view has changed. See this FAQ.

expose a reduced 'navigator' object to frameworker workers

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Trunk
Firefox 17
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 641373 [details] [diff] [review]
expose a subset of navigator and add navigator specific tests

From https://bugzilla.mozilla.org/show_bug.cgi?id=770679#c2, we should not expose the full 'navigator' object to workers.

http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workernavigator-object lists what a real DOM worker gets, and our Frameworker should restrict things to this list.
Attachment #641373 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

5 years ago
Created attachment 641375 [details] [diff] [review]
expose a subset of navigator and add navigator specific tests and include __exposedProps__

This patch adds __exposedProps__ to the navigator object to prevent warnings.
Attachment #641373 - Attachment is obsolete: true
Attachment #641373 - Flags: review?(gavin.sharp)
Attachment #641375 - Flags: review?(gavin.sharp)
Comment on attachment 641375 [details] [diff] [review]
expose a subset of navigator and add navigator specific tests and include __exposedProps__

thanks!
Attachment #641375 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/777fbc99f40b
Whiteboard: [in-testsuite]
Flags: in-testsuite+
Whiteboard: [in-testsuite]
Target Milestone: --- → Firefox 16
Version: unspecified → Trunk
(Assignee)

Comment 4

5 years ago
backed out due to leaks
(Assignee)

Comment 5

5 years ago
Created attachment 642489 [details] [diff] [review]
Old patch neglected to call worker.terminate() which caused leaks in the test

Same as old patch except one line added:  worker.terminate();
Attachment #641375 - Attachment is obsolete: true
Attachment #642489 - Flags: review?(gavin.sharp)
Attachment #642489 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 6

5 years ago
New patch pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/6d2002bd64c5
Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.
Target Milestone: Firefox 16 → Firefox 17
Blocks: 770679
https://hg.mozilla.org/mozilla-central/rev/6d2002bd64c5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 776553
No longer depends on: 776553
You need to log in before you can comment on or make changes to this bug.