773160 - expose a reduced 'navigator' object to frameworker workers

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: expose a subset of navigator and add navigator specific tests

From https://bugzilla.mozilla.org/show_bug.cgi?id=770679#c2, we should not expose the full 'navigator' object to workers.

http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workernavigator-object lists what a real DOM worker gets, and our Frameworker should restrict things to this list.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: expose a subset of navigator and add navigator specific tests and include __exposedProps__

This patch adds __exposedProps__ to the navigator object to prevent warnings.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 641375 [details] [diff] [review]
expose a subset of navigator and add navigator specific tests and include __exposedProps__

thanks!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/777fbc99f40b

Comment 4

[Mark Hammond [:markh] [:mhammond]]

backed out due to leaks

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: Old patch neglected to call worker.terminate() which caused leaks in the test

Same as old patch except one line added:  worker.terminate();

Comment 6

[Mark Hammond [:markh] [:mhammond]]

New patch pushed as https://hg.mozilla.org/integration/mozilla-inbound/rev/6d2002bd64c5

Comment 7

[Ed Morley [:emorley]]

Didn't make it to mozilla-central before the uplift (merge was blocked on bug 774259). Adjusting milestone accordingly.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d2002bd64c5