Closed Bug 773250 Opened 12 years ago Closed 12 years ago

Request Desktop Site sometimes does not work (Nightly on tablet)

Categories

(Firefox for Android Graveyard :: General, defect)

16 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: djprius, Assigned: bnicholson)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0
Build ID: 20120601045813

Steps to reproduce:

Using Acer A100 (4.0.3) 7" tablet with Nightly

1.  Link brought me to mobile version of Website
2.  Request Destop Site did not function as intended

To replicate:
1.  Go to: m.wired.com
2.  Use Request Desktop Site menu item (won't change to destop display of website)


Actual results:

I have found that some sites which I have reached through links will not respond to Request Desktop site.

Today I pursued one of these: Wired.com.  I found that if the link takes me to "m.xyz.com", the Request Desktop Site does not work.

On Wired, there is a "view full website link" which gave me what I wanted.

It would be nice if Request Desktop Site worked in all cases, even if one is taken to a URL that is a discrete mobile version.  Can this be done?
Blocks: 766406
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → Android
Hardware: x86_64 → ARM
There's 2 problems here:

1) We are only changing the UA for the primary document. I'm not sure why we have this check; I think every resource on the page should be requested using the same UA.

2) Apparently, wired.com uses cookies to remember the UA preference. I've seen the same thing on dailyshow.com. Presumably, dailyshow.com wants to prevent mobile users from watching full episodes, so they lock the user into mobile mode once the site has been visited with a mobile UA. I'm not sure why wired.com does this, but short of evangelism, there isn't much we can do (and it appears they've gone out of their way to cause this behavior). If you want to look at desktop versions of these sites, you'll have to clear your cookies, switch the tab to desktop mode, and then go to the site.

This patch fixes #1.
Assignee: nobody → bnicholson
Attachment #641563 - Flags: review?(mark.finkle)
Comment on attachment 641563 [details] [diff] [review]
Change UA for all resources, not just main document

Seems like the right thing to do. You did have this in your patch for bug 697857, but I don't think we need it. We get the DOM window for the request, so we should be good for all requests needed for a window.
Attachment #641563 - Flags: review?(mark.finkle) → review+
Needed for Aurora?
Comment on attachment 641563 [details] [diff] [review]
Change UA for all resources, not just main document

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 766406
User impact if declined: request desktop site may not work on some pages
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none
Attachment #641563 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/61cee6de0360
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 641563 [details] [diff] [review]
Change UA for all resources, not just main document

needed for the feature to work well. mobile-only.
Attachment #641563 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Not sure if "reopened" is correct way to continue discussion; if not, please excuse.)

  My understanding is that this "resolution" does NOT fix my issue for sites like Wired.com.  If so, this is not acceptable in my view. 

  From my reading of your comments, I understand that my issue could be solved if there were a preference in Settings for "always use Desktop view".  Opera Mobile has this and it works fine on Wired.com.

  With millions of Google Nexus to be sold in the next few months, I hope, this preference should be added now.

David
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This bug was broken in to two issues, one of which was addressed. We would open a new bug to track the other issue.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Opened bug 774248. Please add comments for other improvements there.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.