773288 - Send links to repacked version of AMO addons to authors.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

Here is a tracking bug, as IT bugs are private, it will be easier to talk about this action here and track progress of all sub-actions.

Jeff/dcm, I will be able to provide the final list of safely-repackable addons IDs when related IT bugs are resolved or close to be and if you give me the green signal to go.
We need to agree on timings. We are going to decide to repack for one particular SDK version.
Are we going to repack with 1.8.1 ?
Or are we waiting for 1.9rc or 1.9 in order to repack with an SDK version that works with Nightly ? (bug 768584)


Here is a somekind of "release candidate" for the repack (487 addons):
  http://anacomda.hd.free.fr/repacked/safe/
List of addons ids:
  http://anacomda.hd.free.fr/repacked/safe/addons-safely-repackable
Addons SDK version and dependencies:
  http://anacomda.hd.free.fr/repacked/safe/addons-deps

So here I'm extra safe, I'm only repacking if all possible tests are green:
 - only high level API usage from addon-kit
 - having only one package (i.e. depends only on addon-kit/api-utils and no other extra package like Erik's one about toolbars)
 - all SDK files have valid checksums (no patched SDK modules)
 - accept only addons packed with released version of the SDK (i.e. which have a tag in git)
 - try to detect xpi that have been manually patched by author. I repack with the exact same SDK version and refuse any addons which doesn't repack identically. (For example various addons modified install.rdf to add localization stuff or change the version, addon name ...) [It allowed me to see various pitfall in the repacker and verify that it works very well now!]

Most of this being done by following python script:
  https://github.com/ochameau/jetpack-repacker

So this list is very safe. We can send a second wave of repack mails with rejected addons, but with some more warning messages.

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Let's re-pack with SDK 1.8.2, as it includes a fix for bug 768584.

Comment 2

[Alexandre Poirot [:ochameau]]

I've downloaded an updated list of addons yesterday and repacked them:
http://anacomda.hd.free.fr/repacked/

You can find details on these addons here (sdk version, dependencies):
http://anacomda.hd.free.fr/repacked/repacked-dependencies

And the list of addons id:
http://anacomda.hd.free.fr/repacked/repacked-list

I tried some random addons with successes, but I'll try some more on Monday.

Comment 3

[Alexandre Poirot [:ochameau]]

I tested some more addons and all addons I tested still works while being repacked.
But some addons were already broken before repack and keep being broken!
Some of them are using google translate API which seems to have changed.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Any add-on that uses the google translation api is broken, because google cut off access tot hat months ago. it's why we changed our example to use something else instead.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Yeah, I'm wondering how many of those addons are just copies of our old tutorial.

Comment 6

[Alexandre Poirot [:ochameau]]

There is 20 such addons:
259583
296532
304407
306529
312356
318218
328833
331317
332431
333087
333473
335335
337044
337300
337321
337498
337517
337576
344854
353045

But I think we diverge from the original purpose of this bug ;)

Comment 7

[Alexandre Poirot [:ochameau]]

Jeff, would you be able to upload xpi files available here:
  http://anacomda.hd.free.fr/repacked/
to mozilla's ftp?

Comment 8

[Jeff Griffiths (:canuckistani) (:⚡︎)]

In progress.

Comment 9

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Done: 

https://releases.mozilla.com/re-packs/

Comment 10

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Current status: waiting until Alex gets back from vacation for the next steps.

Next steps:

* generate a list with each add-on author, their add-ons, and for each add-on a link to the re-apcked xpi
* draft an email template explaining project and including a call to action to test the add-on
* devise a feedback mechanism for authors to ask questions regarding this
* with these 2 pieces, we send teh emails
* we also blog about it

Comment 11

[Alexandre Poirot [:ochameau]]

Now that 1.9 is released, I'll have to repack addons to this new version.
So that you can clear https://releases.mozilla.com/re-packs/

I may wait for next steps to be ready before repacking xpi again and have the most up to date addon list.

Comment 12

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Okay, I've deleted the existing re-packs for now. When you get a minute, we need to talk about bug 783108 as well.

Comment 13

[Dave Townsend [:mossop]]

Didn't we finish this?