773498 - Language served doesn't change upon changing my browser->Language preferences

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/en-US
2. Nightly->Preferences. Change your default language to es-Es
3. Reload Marketplace

expected behavior:
Content is now served in Spanish

observed behavior:
Content is still served in English.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/cd9a9e3

I was letting the cookie take precedence over what you set in your browser. I've changed it so that the "Accept-Language" header that the browser sends takes precedence. That certainly makes more sense.

Comment 2

[krupa raj[:krupa]]

This works the first time I change the Language preference. But switching between languages doesn't reflect on the site.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/ad2a887

Comment 4

[krupa raj[:krupa]]

This is not fixed.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/b4c6c2b

This seems to work pretty reliably now. Don't whack it too hard!

Comment 6

[krupa raj[:krupa]]

STR:
1. Load https://marketplace-dev.allizom.org/
2. Browser->Preferences->Languages
3. Choose es-ES as the default language
4. Reload marketplace
5. Repeat step #2 and change the language to en-US

expected behavior:
Marketplace loads in en-US after step #5

observed behavior:
marketplace still loads in es-es after step #5


screencast: http://screencast.com/t/BmLQVW61h83

Comment 7

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/a9d84d9

Comment 8

[krupa raj[:krupa]]

This seems to be working.