773641 - Change in-product Twitter search icon

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Twitter changed their icons and they don't want people using the T icon anymore

http://twitter.com/logo

Comment 1

[:Margaret Leibovic]

We would need to update the search plugin:
http://mxr.mozilla.org/mozilla-central/source/mobile/locales/en-US/searchplugins/twitter.xml#7

I feel like we usually work with our search partners to get these icons from them. Cc'ing Kev, since he would know.

(FWIW, the desktop search plugin has the new icon, but we should use a higher resolution version for mobile.)

Comment 2

[Kev Needham [:kev]]

I'll reach out to Twitter and ask for an updated base64 encoded image.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kev [:kev] Needham from comment #2)
> I'll reach out to Twitter and ask for an updated base64 encoded image.

32x32 please

Comment 4

[Kev Needham [:kev]]

Because I'm awesome, I dropped the ball on this. I hope to have an updated icon from Twitter in the next 48 hours. Apologies.

Comment 5

[Kev Needham [:kev]]

Attachment: New Twitter Icon 32x32

This icon should be used in both mobile and desktop, so should go into central. It's pending final approval from Twitter, but has been created per their request from the source at http://twitter.com/logo/

Comment 6

[:Margaret Leibovic]

(In reply to Kev [:kev] Needham from comment #5)
> Created attachment 655999 [details]
> New Twitter Icon 32x32
> 
> This icon should be used in both mobile and desktop, so should go into
> central. It's pending final approval from Twitter, but has been created per
> their request from the source at http://twitter.com/logo/

Thanks! However, Gavin says that we'll want a 16x16 icon for desktop.

Comment 7

[Kev Needham [:kev]]

Tell Gavin he'll use the 32x32, and like it! :)

Comment 8

[Kev Needham [:kev]]

Attachment: New Twitter Icon 16x16

16 x 16, because I suspect my previous comment will not be accepted.

Comment 9

[:Margaret Leibovic]

Attachment: patch for mobile

Comment 10

[:Margaret Leibovic]

Attachment: mobile screenshot

Comment 11

[:Margaret Leibovic]

Attachment: patch for desktop

Comment 12

[:Margaret Leibovic]

Attachment: desktop screenshot

I can't tell if this is actually blurry, or if it's my retina display being dumb. In any case, the icon is correct :)

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 656204 [details] [diff] [review]
patch for desktop

We should probably also file a bug to update twitter-ja (ja locale has their own fork).

Comment 14

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3a789ca296a
https://hg.mozilla.org/integration/mozilla-inbound/rev/fed9bcc5862f

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3a789ca296a
https://hg.mozilla.org/mozilla-central/rev/fed9bcc5862f

Comment 16

[Aaron Train [:aaronmt]]

Channel uplift?

Comment 17

[Mark Finkle (:mfinkle) (use needinfo?)]

Certainly seems safe enough to push to Aurora, maybe even Beta

Comment 18

[:Margaret Leibovic]

Comment on attachment 656194 [details] [diff] [review]
patch for mobile

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: old twitter icon will be used for search
Testing completed (on m-c, etc.): landed on m-c 8/29
Risk to taking this patch (and alternatives if risky): low-risk image swap
String or UUID changes made by this patch: n/a (although this change is in locales directory, so we should double check with Pike that this wouldn't cause any problems)

Gavin, do you want me to try to uplift the desktop change as well?

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 656204 [details] [diff] [review]
patch for desktop

[Triage Comment]
sure

Comment 20

[Alex Keybl [:akeybl]]

Comment on attachment 656194 [details] [diff] [review]
patch for mobile

I don't expect there to be any l10n fallout for this resource switch. Approved for branches.

Comment 21

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/182d1fe4f2db
https://hg.mozilla.org/releases/mozilla-aurora/rev/7ec3cb3adef9

https://hg.mozilla.org/releases/mozilla-beta/rev/079b6572fc8c
https://hg.mozilla.org/releases/mozilla-beta/rev/2f4c512e4f3e