Stop using profile directory for Device Storage testings

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Hmm, any context?
(Assignee)

Comment 2

5 years ago
Created attachment 641967 [details] [diff] [review]
patch v.1
Attachment #641967 - Flags: review?(jmaher)
Comment on attachment 641967 [details] [diff] [review]
patch v.1

Review of attachment 641967 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks good, no red flags.  A bit out of my league for what I know.

::: dom/devicestorage/test/devicestorage_common.js
@@ +18,5 @@
> +  try {
> +    const Cc = SpecialPowers.wrap(Components).classes;
> +    const Ci = Components.interfaces;
> +    var directoryService = Cc["@mozilla.org/file/directory_service;1"].getService(Ci.nsIProperties);
> +    var f = directoryService.get("TmpD", Components.interfaces.nsIFile);

do you have access to Ci.nsiFile?
Attachment #641967 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

5 years ago
wierd, i didn't.  but I will fix the patch so that it uses the wrapped.
(Assignee)

Updated

5 years ago
Summary: Stop using profile directory for testings → Stop using profile directory for Device Storage testings
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9d877d78294
Sorry, but your push had to be backed out due to compilation errors on all platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7db81ae082e7

/builds/slave/m-in-lnx/build/dom/ipc/PContent.ipdl:166: error: ctor for protocol `PDeviceStorageRequest', which is not managed by protocol `PContent'
Specification is not well typed.
(Assignee)

Comment 7

5 years ago
bad rebase - https://hg.mozilla.org/integration/mozilla-inbound/rev/ebaadef40580
https://hg.mozilla.org/mozilla-central/rev/ebaadef40580
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Depends on: 774368
You need to log in before you can comment on or make changes to this bug.