773931 - Install Ganglia to puppetAgain servers

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Justin Wood (:Callek)]

Attachment: add ganglia

Ok, this should do it, and smartly. And this was the best way I could come up with it.

I noticed that my local hg diff is giving me really strange diffs (relating to line endings and a few file modes -- I'll clean that up with the EOF newlines before landing, or in a new patch if required)

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 642192 [details] [diff] [review]
add ganglia

Review of attachment 642192 [details] [diff] [review]:
-----------------------------------------------------------------

Sudden thought, how are we handling the ganglia road in AWS with those systems? Do I need to rework any of this to support an "don't install ganglia in aws" or something, or should this format work. additional r? to catlee for the AWS Q's (I don't want to break you)

Comment 2

[Kim Moir [:kmoir] ET]

Comment on attachment 642192 [details] [diff] [review]
add ganglia

Review of attachment 642192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I'm also curious about the ramifications of this patch on the machines running on AWS.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 642192 [details] [diff] [review]
add ganglia

Review of attachment 642192 [details] [diff] [review]:
-----------------------------------------------------------------

Aside from my qualms about the complexity of the $::config::ganglia_config_class, I think this looks good.

::: manifests/extlookup/moco-config.csv
@@ +3,5 @@
>  puppet_servers,releng-puppet1.build.mtv1.mozilla.com,releng-puppet1.build.scl1.mozilla.com,releng-puppet1.srv.releng.scl3.mozilla.com
>  data_servers,releng-puppet1.build.mtv1.mozilla.com,releng-puppet1.build.scl1.mozilla.com,releng-puppet1.srv.releng.scl3.mozilla.com
>  nrpe_allowed_hosts,"10.2.71.20,10.12.75.9,127.0.0.1,10.26.75.30"
>  ntp_server,ntp.build.mozilla.org
> +ganglia_config_class,ganglia::config-moco

This, or any other addition to CSV, will need a default, too.

::: modules/ganglia/manifests/config-moco.pp
@@ +16,5 @@
> +            $cluster = "RelEngMTV1"
> +            $addr = "239.2.11.203"
> +        }
> +        default: {
> +            fail("Unsupported fqdn")

I bet you could fix this for AWS -- and everywhere else -- by just changing this to set $cluster = "none", and conditionalizing the rest on that value.  You may need to move the case statement into ganglia::settings, in that case.  I *think* this would remove the need for the CSV setting and per-site classes entirely.  What this might miss is cases where a regex is wrong or doesn't match a new host, and puppet happily fails to install ganglia.  *That* could be fixed with a $::config::use_ganglia, which if true would cause puppet to fail if none of the regexes matched.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 642192 [details] [diff] [review]
add ganglia

So, after some discussion in IRC, I'm ok with specifying the class name in the CSV.  It does make it very clear who owns that particular configuration.

Callek pointed out that the extlookup call specifies a default of "", but I'd still like to have a line in the default-config.csv so that file represents the full set of available variables.

r+ with that one-line addition.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 642192 [details] [diff] [review]
add ganglia

http://hg.mozilla.org/build/puppet/rev/1416babed6ab

Leaving open for docs, and clearing catlee's review. Rail was ok if this broke AWS and said him/catlee would tackle fixing it if needed.

Comment 7

[Justin Wood (:Callek)]

Resolving in favor of Docs Bug 816921