774130 - Implement desktop background on GNOME

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[[e-mail]]

This is just the basic implementation that works with our existing context menuitem.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Ian Neal]

Comment on attachment 642447 [details] [diff] [review]
Proposed patch

>+++ b/suite/shell/src/nsGNOMEShellService.cpp

>+#include "nsIStringBundle.h"
>+#include "nsIImageLoadingContent.h"
>+#include "nsIDOMElement.h"
Firefox seems to use "nsIDOMHTMLImageElement.h" here.

>+#include "imgIRequest.h"
>+#include "imgIContainer.h"
>+#include "nsIImageToPixbuf.h"
Firefox seems to #ifdef MOZ_WIDGET_GTK2 this.

>+  // Set desktop wallpaper filling style
>+  nsCAutoString options;
>+  if (aPosition == BACKGROUND_TILE)
>+    options.AssignLiteral("wallpaper");
>+  else if (aPosition == BACKGROUND_STRETCH)
>+    options.AssignLiteral("stretched");
>+  else if (aPosition == BACKGROUND_FILL)
>+    options.AssignLiteral("zoom");
>+  else if (aPosition == BACKGROUND_FIT)
>+    options.AssignLiteral("scaled");
>+  else
>+    options.AssignLiteral("centered");
Would using switch here be possible so it is similar to the Windows one?

>+    // Set the image to an empty string first to force a refresh
>+    // (since we could be writing a new image on top of an existing
>+    // Firefox_wallpaper.png and nautilus doesn't monitor the file for changes)
Do we really mean "Firefox_wallpaper.png" here?

r=me with those answered/addressed

Comment 3

[[e-mail]]

(In reply to Ian Neal from comment #2)
> >+#include "nsIDOMElement.h"
> Firefox seems to use "nsIDOMHTMLImageElement.h" here.
We don't actually use the specific interface.

> >+#include "nsIImageToPixbuf.h"
> Firefox seems to #ifdef MOZ_WIDGET_GTK2 this.
We only build this file on GTK2 builds as per the Makefile.

> >+  // Set desktop wallpaper filling style
> Would using switch here be possible so it is similar to the Windows one?
Yeah, I noticed that when writing bug 773999; I'll change it.

> >+    // Firefox_wallpaper.png and nautilus doesn't monitor the file for changes)
> Do we really mean "Firefox_wallpaper.png" here?
Oops :-[

Comment 4

[[e-mail]]

Attachment: Addressed review comments

Comment 6

[[e-mail]]

Pushed comm-central changeset 84f1af072b63.

Comment 7

[[e-mail]]

Oops, forgot to mark fixed at the same time...