Closed Bug 771941 Opened 8 years ago Closed 8 years ago

Port |Bug 526717 - remove non-working "Set as desktop background" from the UI for unsupported desktops| to SeaMonkey

Categories

(SeaMonkey :: OS Integration, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Currently there is no way to tell whether a shell service supports setting the desktop background, but this will allow us to protect each use of the shell service with try/catch so that we can then rename the shell feed service to the shell service and then implement each part of the shell service independently.
Try run for 68088407581a is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=68088407581a
Results (out of 10 total builds):
    failure: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-68088407581a
Attached patch Proposed patchSplinter Review
This patch was tested on Linux by creating a dummy shell service that doesn't implement anything. (Much like the current one, then!)

Don't worry about the try failures, the c-c try server doesn't really support SeaMonkey...
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #640114 - Flags: review?(iann_bugzilla)
OS: Linux → Windows XP
Hardware: x86_64 → x86
Blocks: 771954
Try run for fd9b9403cf97 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=fd9b9403cf97
Results (out of 10 total builds):
    failure: 10
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/neil@parkwaycc.co.uk-fd9b9403cf97
oops wrong tab.

> Note that users of the shell service need to expect its methods to throw.
The Firefox version doesn't throw. Why do we need to throw?
Blocks: 632585
Comment on attachment 640114 [details] [diff] [review]
Proposed patch

>+++ b/suite/shell/src/nsGNOMEShellService.cpp
>+nsGNOMEShellService::GetCanSetDesktopBackground(bool* aResult)
>+{
>+  return NS_ERROR_NOT_IMPLEMENTED;
>+}
>+
>+NS_IMETHODIMP
> nsGNOMEShellService::SetDesktopBackground(nsIDOMElement* aElement, 
>                                           PRInt32 aPosition)
> {
>   return NS_ERROR_NOT_IMPLEMENTED;
> }
>+++ b/suite/shell/src/nsMacShellService.cpp
> NS_IMETHODIMP
>+nsMacShellService::GetCanSetDesktopBackground(bool* aResult)
>+{
>+  return NS_ERROR_NOT_IMPLEMENTED;
>+}
>+
>+NS_IMETHODIMP
> nsMacShellService::SetDesktopBackground(nsIDOMElement* aElement,
>                                             PRInt32 aPosition)
> {
>   return NS_ERROR_NOT_IMPLEMENTED;
> }
Why do we do different to Firefox for both GNOME and Mac? Is there a bug for porting?
Attachment #640114 - Flags: review?(iann_bugzilla) → review+
Yeah, we can't port the "canSetDesktopBackground" code without the appropriate "setDesktopBackground" code is ported, bug 127206 and bug 215532 respectively.
Pushed comm-central changeset 119a5a84e00e.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 774130
You need to log in before you can comment on or make changes to this bug.