Webapp uninstallation on Linux through mozApps uninstall function

RESOLVED FIXED in Firefox 17

Status

Firefox Graveyard
Web Apps
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

({productwanted})

Trunk
Firefox 17
All
Linux
productwanted

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 642456 [details] [diff] [review]
Patch
Attachment #642456 - Flags: review?(felipc)

Updated

5 years ago
Summary: Webapp uninstallation on Linux through mozApps uninstall function → Webapp uninstallation on Linux and OS X through mozApps uninstall function
(Assignee)

Updated

5 years ago
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Comment on attachment 642456 [details] [diff] [review]
Patch

thanks Marco. WebappOSUtils.jsm is already in the tree so we should implement this there directly. Also, turns out XP_UNIX is also defined both for Android and B2G, so I'm trying to come up with a proper solution on how to handle this. Ideas appreaciated :)
Attachment #642456 - Flags: review?(felipc) → feedback+

Updated

5 years ago
status-firefox16: --- → wontfix

Updated

5 years ago
Keywords: productwanted
(Assignee)

Comment 2

5 years ago
Created attachment 649159 [details] [diff] [review]
WIP

What do you think about the approach about the XP_UNIX problem? Is it too chaotic?
Attachment #642456 - Attachment is obsolete: true
Attachment #649159 - Flags: feedback?(felipc)
(Assignee)

Comment 3

5 years ago
Created attachment 649161 [details] [diff] [review]
WIP

Oops, forgot to qref.
Attachment #649159 - Attachment is obsolete: true
Attachment #649159 - Flags: feedback?(felipc)
Attachment #649161 - Flags: feedback?(felipc)
Comment on attachment 649161 [details] [diff] [review]
WIP

Review of attachment 649161 [details] [diff] [review]:
-----------------------------------------------------------------

So instead let's do the better aprroach that we discussed about just dispatching a webapps-uninstall notification in Webapps.jsm, and then webappsUI can catch that notification and call WebappOSUtils.uninstall.  This will ensure this code is only used in desktop.

Moving forward we might split this file into one per OS (still thinking about that), but let's not do this in this bug

::: toolkit/webapps/WebappOSUtils.jsm
@@ +95,5 @@
> +
> +    try {
> +      if (exeFile.exists()) {
> +        var process = Components.classes["@mozilla.org/process/util;1"]  
> +                                        .createInstance(Components.interfaces.nsIProcess);

you can use Cc and Ci here
Attachment #649161 - Flags: feedback?(felipc) → feedback+
(Assignee)

Comment 5

5 years ago
Created attachment 649899 [details] [diff] [review]
Patch
Attachment #649161 - Attachment is obsolete: true
Attachment #649899 - Flags: review?(felipc)
Comment on attachment 649899 [details] [diff] [review]
Patch

Review of attachment 649899 [details] [diff] [review]:
-----------------------------------------------------------------

great :)
Attachment #649899 - Flags: review?(felipc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcd9fb49866b
Summary: Webapp uninstallation on Linux and OS X through mozApps uninstall function → Webapp uninstallation on Linux through mozApps uninstall function
Target Milestone: --- → Firefox 17

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/bcd9fb49866b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

5 years ago
Comment on attachment 649899 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: Users won't be able to automatically uninstall applications.
Testing completed (on m-c, etc.): On central for some days.
Risk to taking this patch (and alternatives if risky): No risk.
String or UUID changes made by this patch: None.

We need also the patch in bug 761806.
Attachment #649899 - Flags: approval-mozilla-aurora?
Comment on attachment 649899 [details] [diff] [review]
Patch

same thing as bug 761806, this is a wontfix for 16 and can ride the trains.
Attachment #649899 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
QA Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.