Linux styling for Social toolbar UI

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: jaws)

Tracking

Trunk
Firefox 17
All
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Bug 771826 implemented an (off by default) social toolbar button functionality. That UI needs to be styled for Linux - the initial patch only covered Windows+Mac.
I'll take this.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Created attachment 647355 [details] [diff] [review]
Patch

This patch copies many of the styles from pinstripe and winstripe, but keeps the button looking native and fitting in with the other toolbarbuttons on Linux. (Tested with Ubuntu)
Attachment #647355 - Flags: review?(gavin.sharp)
Attachment #647355 - Flags: review?(dao)
Comment on attachment 647355 [details] [diff] [review]
Patch

>diff --git a/browser/themes/gnomestripe/browser.css b/browser/themes/gnomestripe/browser.css

>+#social-toolbar-button {
>+  -moz-box-pack: center;

Why is this needed? Should we set pack="center" on the button itself? We don't currently set this on Windows/Mac.
Attachment #647355 - Flags: review?(gavin.sharp)
Attachment #647355 - Flags: review?(dao)
Attachment #647355 - Flags: review+
The pack="center" centered the MoTown icon vertically, and it is probably something good to have in case other providers don't give us the exact size icon we're expecting.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb6de405463b
Flags: in-testsuite-
Whiteboard: [fx16]
Target Milestone: --- → Firefox 17

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/cb6de405463b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.