774174 - Linux styling for Social toolbar UI

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 771826 implemented an (off by default) social toolbar button functionality. That UI needs to be styled for Linux - the initial patch only covered Windows+Mac.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'll take this.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

This patch copies many of the styles from pinstripe and winstripe, but keeps the button looking native and fitting in with the other toolbarbuttons on Linux. (Tested with Ubuntu)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 647355 [details] [diff] [review]
Patch

>diff --git a/browser/themes/gnomestripe/browser.css b/browser/themes/gnomestripe/browser.css

>+#social-toolbar-button {
>+  -moz-box-pack: center;

Why is this needed? Should we set pack="center" on the button itself? We don't currently set this on Windows/Mac.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

The pack="center" centered the MoTown icon vertically, and it is probably something good to have in case other providers don't give us the exact size icon we're expecting.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb6de405463b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cb6de405463b