Last Comment Bug 774174 - Linux styling for Social toolbar UI
: Linux styling for Social toolbar UI
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: Trunk
: All Linux
-- normal (vote)
: Firefox 17
Assigned To: Jared Wein [:jaws] (please needinfo? me)
: Shane Caraveo (:mixedpuppy)
Depends on:
Blocks: 771826
  Show dependency treegraph
Reported: 2012-07-15 21:20 PDT by :Gavin Sharp [email:]
Modified: 2012-08-04 11:17 PDT (History)
4 users (show)
jaws: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (3.03 KB, patch)
2012-07-30 16:47 PDT, Jared Wein [:jaws] (please needinfo? me) review+
Details | Diff | Splinter Review

Description User image :Gavin Sharp [email:] 2012-07-15 21:20:05 PDT
Bug 771826 implemented an (off by default) social toolbar button functionality. That UI needs to be styled for Linux - the initial patch only covered Windows+Mac.
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2012-07-20 14:28:53 PDT
I'll take this.
Comment 2 User image Jared Wein [:jaws] (please needinfo? me) 2012-07-30 16:47:12 PDT
Created attachment 647355 [details] [diff] [review]

This patch copies many of the styles from pinstripe and winstripe, but keeps the button looking native and fitting in with the other toolbarbuttons on Linux. (Tested with Ubuntu)
Comment 3 User image :Gavin Sharp [email:] 2012-08-03 17:37:50 PDT
Comment on attachment 647355 [details] [diff] [review]

>diff --git a/browser/themes/gnomestripe/browser.css b/browser/themes/gnomestripe/browser.css

>+#social-toolbar-button {
>+  -moz-box-pack: center;

Why is this needed? Should we set pack="center" on the button itself? We don't currently set this on Windows/Mac.
Comment 4 User image Jared Wein [:jaws] (please needinfo? me) 2012-08-03 18:51:29 PDT
The pack="center" centered the MoTown icon vertically, and it is probably something good to have in case other providers don't give us the exact size icon we're expecting.
Comment 5 User image Ed Morley [:emorley] 2012-08-04 11:17:55 PDT

Note You need to log in before you can comment on or make changes to this bug.