774205 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoInputConnection$<n>.run(GeckoInputConnection.java) on ICS and JB

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Scoobidiver (away)]

It first appeared in 16.0a1/20120714. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6489be1890c0&tochange=0602e44ac248

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoInputConnection$1.run(GeckoInputConnection.java:1011)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4745)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+org.mozilla.gecko.GeckoInputConnection%241.run%28GeckoInputConnection.java%29

Comment 1

[Scoobidiver (away)]

It currently affect ICS and JB like bug 774206.

Comment 2

[Brian Nicholson (:bnicholson)]

This is probably another NPE from "Don't keep activities" being on.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Guard against null layercontroller

It looks like the code assumes getView() will always be non-null, except possibly in the postOnUiThread runnables. That seems reasonable to me, assuming that all the other invocations are directly on the UI thread and are coming while the view is alive and well.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 644924 [details] [diff] [review]
Guard against null layercontroller

Review of attachment 644924 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/727381afb1be

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/727381afb1be

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 644924 [details] [diff] [review]
Guard against null layercontroller

[Approval Request Comment]
Bug caused by (feature/regressing bug #): exposed by bug 769269
User impact if declined: crash may happen if going to the awesomescreen while keyboard is up
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile only, low risk
String or UUID changes made by this patch: none

Comment 8

[Scoobidiver (away)]

15.0b2 is affected while 15.0b1 wasn't.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 644924 [details] [diff] [review]
Guard against null layercontroller

Requesting for beta as well.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 644924 [details] [diff] [review]
Guard against null layercontroller

[Triage Comment]
Low risk fix for a crash regression. Approved for Aurora 16 and Beta 15.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/00738d54c024
https://hg.mozilla.org/releases/mozilla-beta/rev/f614c8f107c5

Comment 12

[Cristian Nicolae (:xti)]

All latest crashes occurred (due to this crash report) on Firefox 15 Beta (2012-07-24), but there is no crash on Firefox 15 Release channel, 16 Beta or 17 Aurora.

Closing bug as verified fixed.

--
Device: Galaxy Note
OS: Android 4.0.4