Last Comment Bug 774463 - figure out why CheckNewScriptProperties doesn't work on nested functions
: figure out why CheckNewScriptProperties doesn't work on nested functions
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: general
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-07-16 14:31 PDT by Luke Wagner [:luke]
Modified: 2012-08-16 15:23 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Description User image Luke Wagner [:luke] 2012-07-16 14:31:30 PDT
The non-reentrant closure optimization patch added a check to CheckNewScriptProperties to bail on nested functions:

when this optimization was removed in bug 765956, this check was removed.  However, this caused regressions (bug 773929).  The quick fix was to go back to disallowing this function on nested functions (now using script->enclosingStaticScope), but it would be really good to understand why this restriction is necessary in the first place.
Comment 1 User image Luke Wagner [:luke] 2012-08-16 15:23:22 PDT
I tracked it down to bug 783396.  Indeed, the nested functions were a red herring and only served to turn off the new-script analysis on the particular YouTube script in question.

Note You need to log in before you can comment on or make changes to this bug.