The default bug view has changed. See this FAQ.

merge SocialProvider into SocialService.jsm

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: markh)

Tracking

unspecified
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

SocialProvider is only used in SocialService.jsm, and arguably its constructor shouldn't be exposed at all, so we should just put it in SocialService.jsm and not export its symbol, IMO.

(This will also have a miniscule impact on memory usage, per bug 773845.)
(Assignee)

Comment 1

5 years ago
Created attachment 642839 [details] [diff] [review]
Merge 'em

Fairly trivial patch - asking Shane for review to share the review love around!
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #642839 - Flags: review?(mixedpuppy)
Attachment #642839 - Flags: review?(mixedpuppy) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/33ce023a9cb3
https://hg.mozilla.org/mozilla-central/rev/33ce023a9cb3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.