Closed
Bug 774543
Opened 12 years ago
Closed 12 years ago
merge SocialProvider into SocialService.jsm
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: Gavin, Assigned: markh)
Details
Attachments
(1 file)
|
11.37 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
SocialProvider is only used in SocialService.jsm, and arguably its constructor shouldn't be exposed at all, so we should just put it in SocialService.jsm and not export its symbol, IMO. (This will also have a miniscule impact on memory usage, per bug 773845.)
|
Assignee | |
Comment 1•12 years ago
|
||
Fairly trivial patch - asking Shane for review to share the review love around!
|
||
Updated•12 years ago
|
Attachment #642839 -
Flags: review?(mixedpuppy) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/33ce023a9cb3
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/33ce023a9cb3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•