Last Comment Bug 774543 - merge SocialProvider into SocialService.jsm
: merge SocialProvider into SocialService.jsm
Product: Firefox
Classification: Client Software
Component: SocialAPI (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 17
Assigned To: Mark Hammond [:markh]
: Shane Caraveo (:mixedpuppy)
Depends on:
  Show dependency treegraph
Reported: 2012-07-16 17:34 PDT by :Gavin Sharp [email:]
Modified: 2012-07-18 05:53 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Merge 'em (11.37 KB, patch)
2012-07-16 19:37 PDT, Mark Hammond [:markh]
mixedpuppy: review+
Details | Diff | Splinter Review

Description User image :Gavin Sharp [email:] 2012-07-16 17:34:03 PDT
SocialProvider is only used in SocialService.jsm, and arguably its constructor shouldn't be exposed at all, so we should just put it in SocialService.jsm and not export its symbol, IMO.

(This will also have a miniscule impact on memory usage, per bug 773845.)
Comment 1 User image Mark Hammond [:markh] 2012-07-16 19:37:45 PDT
Created attachment 642839 [details] [diff] [review]
Merge 'em

Fairly trivial patch - asking Shane for review to share the review love around!
Comment 3 User image Ed Morley [:emorley] 2012-07-18 05:53:30 PDT

Note You need to log in before you can comment on or make changes to this bug.