774777 - [stage] Bug IDs are not present in any of the reports

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - bug IDs are not present

On both dev and stage - Bug IDs do not appear in the reports.


Steps to reproduce
1. goto a report:
     example:
     - https://crash-stats.allizom.org/topcrasher/byversion/Firefox/15.0a2/7
     - https://crash-stats.allizom.org/report/index/d0e565a1-2749-42f2-af69-b03e02120714

Expected:
Bug ids should be present in the reports

Actual:
They are not present

Comment 1

[Lonnen :lonnen]

I have no insight into stage without a DBA, but I can look into c-s-d.

There are 33 signatures with associated bugs, but the bugs don't show up in the front end. "F1398665248_____________________________", for example, is connected with bug 774092 but that doesn't show in the UI. Same with the other signatures I haphazardly sampled from the bug_associations table.

Comment 2

[Lonnen :lonnen]

curl --data "['signatures=F1398665248_____________________________','nsIFrame::GetView()']" http://socorro-api-dev-internal/bpapi/bugs/ 

=> {"hits": [], "total": 0}

curl --data "signatures=F1398665248_____________________________" http://socorro-api-dev-internal/bpapi/bugs/

=> {"hits": [{"id": 774281, "signature": "F1398665248_____________________________"}, {"id": 774281, "signature": "@0x0 | F1398665248_____________________________"}, {"id": 774092, "signature": "F1398665248_____________________________"}, {"id": 774092, "signature": "@0x0 | F1398665248_____________________________"}], "total": 4}

Not sure I'm formatting multiple signatures correctly. I've tried every variant I can't think of -- json array, with and without single quotes, comma separated list, plus separated list. Can't get anything to return.

Comment 3

[Robert Kaiser]

Gerv, are you still involved in the Bugzilla API? Looks like lonnon has a problem in using it correctly.

Comment 4

[Gervase Markham [:gerv]]

Yes; but this is not the BzAPI, this is Socorro's API. Nothing to do with me :-)

Gerv

Comment 5

[Robert Kaiser]

Oops, sorry. I knew we are using bzAPI to get the data from Bugzilla but forgot to look at the URL lonnen posted here so I haven't realized this is a later step. :)

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

@Lonnen: can you please try 

curl --data "signatures=F1398665248_____________________________+nsIFrame::GetView()" http://socorro-api-dev-internal/bpapi/bugs/

if you did not already? By reading the code that should be the correct form.

Comment 7

[Lonnen :lonnen]

@Adrian tried that yesterday, and again this morning. {"hits": [], "total": 0}

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to Chris Lonnen :lonnen from comment #2)
> curl --data
> "['signatures=F1398665248_____________________________','nsIFrame::
> GetView()']" http://socorro-api-dev-internal/bpapi/bugs/ 
> 
> => {"hits": [], "total": 0}
> 
> curl --data "signatures=F1398665248_____________________________"
> http://socorro-api-dev-internal/bpapi/bugs/
> 
> => {"hits": [{"id": 774281, "signature":
> "F1398665248_____________________________"}, {"id": 774281, "signature":
> "@0x0 | F1398665248_____________________________"}, {"id": 774092,
> "signature": "F1398665248_____________________________"}, {"id": 774092,
> "signature": "@0x0 | F1398665248_____________________________"}], "total": 4}
> 
> Not sure I'm formatting multiple signatures correctly. I've tried every
> variant I can't think of -- json array, with and without single quotes,
> comma separated list, plus separated list. Can't get anything to return.

This should definitely work:

curl -X POST -F signatures='F1398665248_____________________________' -F signatures='nsIFrame::GetView()' http://socorro-api-dev-internal/bpapi/bugs/

I put some debugging logging in the service, and it's definitely not handling multiple arguments correctly.

The old mware code handled this by doing:
signatures = (web.input(id=[]).id,)

Not sure where the new code handles arguments, will look around.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9974620dbc59a7d100a9cfa9cc3405d1fffe8111
Fixes bug 774777 - Fixed POST params in bugs service.

https://github.com/mozilla/socorro/commit/b4f3d3af10825ed20e0560252508ea67e6d437c9
Merge pull request #711 from AdrianGaudebert/774777-fix-post-args-in-bugs-service

Fixes bug 774777 - Fixed POST params in bugs service.

Comment 10

[Lonnen :lonnen]

Attachment: screenshot of the fix working locally

Bug associations in the database are sparse, but are showing up again where we have them.

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage - looks great to me. Thank you *everyone* who worked on resolving this tedious bug.