774870 - Work - Display unicode characters properly in the location field of the Firefox app bar

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Jonathan Wilde [:jwilde]]

It seems like we lost some of the conversion of URL-encoded characters to beautiful unicode characters when detaching XBL bindings for the addressbar.  We should look into how desktop Firefox does this and land an implementation on Metro Firefox.

Test cases:
ar.wikipedia.org
jp.wikipedia.org

Comment 1

[Allison Naaktgeboren :ally]

yea, http://ja.wikipedia.org/wiki/%E3%83%A1%E3%82%A4%E3%83%B3%E3%83%9A%E3%83%BC%E3%82%B8 is kind of ugly. 

What do we need to do to fix this?

Comment 2

[Matt Brubeck (:mbrubeck)]

It looks like we might need to do something similar to this code:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#1109

Comment 3

[Jonathan Wilde [:jwilde]]

p=1

Comment 4

[Jonathan Wilde [:jwilde]]

Attachment: patch v1

Applies code suggested by mbrubeck to getDisplayURI. Existing URI fixup infra seems to handle unicode input to the urlbar properly without modification.

Comment 5

[Frank Yan (:fryn)]

Comment on attachment 762299 [details] [diff] [review]
patch v1

Review of attachment 762299 [details] [diff] [review]:
-----------------------------------------------------------------

très bien!
or, should I say, xn--trs bien-20a ;)

Comment 6

[Jonathan Wilde [:jwilde]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57b121a1d439

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/57b121a1d439