Closed Bug 774920 Opened 13 years ago Closed 13 years ago

Limit number of ids allowed in GET /storage/collection

Categories

(Cloud Services Graveyard :: Server: Sync, defect)

Product:
Cloud Services Graveyard
Component:
Server: Sync
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rfkelly, Unassigned)

References

Details

(Whiteboard: [qa?])

Attachments

(2 files)

docs patch limiting ids-per-get to 100
1.35 KB, patch
gps
: review+
Details | Diff | Splinter Review
code patch limiting max-ids-per-get to 100
2.37 KB, patch
telliott
: review+
Details | Diff | Splinter Review
DELETE /storage/collection?ids=<blah> is hard-limited to 100 ids. We should do the same for GET.
Whiteboard: [qa-]
Whiteboard: [qa-] → [qa?]
Attachment #651234 - Flags: review?(gps)
Attachment #651235 - Flags: review?(telliott)
Just to be clear, this limits the number of ids that can be specified in the "ids" query parameter, not the number that can be returned from the query.
Comment on attachment 651235 [details] [diff] [review] code patch limiting max-ids-per-get to 100 That test is a big square of code - might want to put in some spaces before the comments just to break it up a bit. Code is good.
Attachment #651235 - Flags: review?(telliott) → review+
Comment on attachment 651234 [details] [diff] [review] docs patch limiting ids-per-get to 100 Review of attachment 651234 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #651234 - Flags: review?(gps) → review+
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: