775029 - Clear private data does not clear saved passwords

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Nightly 17.0a1 2012-07-17/ Firefox Mobile 15.0b1
Device: HTC Desire (Android 2.2)/Samsung Galaxy S2 (Android 2.3.4)

Steps to reproduce:
1. Go to mail.yahoo.com.
2. Sign in with any credentials.
3. Choose to save password.
4. Go in settings and clear the private data.
5. Return to yahoo and reload the page.

Expected results:
The login info should be cleared.

Actual results:
Username and passwords are still saved. The password is added if the username is entered.

Comment 1

[Brian Nicholson (:bnicholson)]

It looks like desktop also doesn't clear usernames/passwords when everything in "Clear Recent History" is checked. Instead, it has a separate dialog in Preferences > Security > Saved Passwords. I don't think we want such a detailed passwords management UI (yet), so a simple option to clear all usernames/passwords should suffice.

We can either merge this with another option (Form & Search History?) or create a new item specifically for usernames/passwords. I'm leaning toward the latter since I can see people wanting to clear these independently of other options.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Add "Usernames & passwords" privacy item

Comment 3

[Brian Nicholson (:bnicholson)]

Wasn't sure what to call this...maybe "Saved passwords" would be better (and would match desktop).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643658 [details] [diff] [review]
Add "Usernames & passwords" privacy item

I kinda like "Saved passwords" too. Let's get UX sign off.

Comment 5

[Brian Nicholson (:bnicholson)]

UX agreed. Landed with "Saved passwords":

http://hg.mozilla.org/integration/mozilla-inbound/rev/d34f2b0c4e8b

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 643658 [details] [diff] [review]
Add "Usernames & passwords" privacy item

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 754335
User impact if declined: users cannot clear usernames/passwords
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: added "Saved passwords" string

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d34f2b0c4e8b

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 643658 [details] [diff] [review]
Add "Usernames & passwords" privacy item

[Triage Comment]
We already understand that portions of this feature may not be localized in all supported mobile locales. Approving for branches.

Comment 9

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e38f3d164079

Comment 10

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/d6c8b81545a8

Comment 11

[Brian Nicholson (:bnicholson)]

Follow-up fix:
http://hg.mozilla.org/releases/mozilla-aurora/rev/ea759dc40e08
http://hg.mozilla.org/releases/mozilla-beta/rev/5ffa1e6d0a4a

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Follow up fixes should cause aurora to spike down tomorrow.  Thanks, Brian!