77517 - Composer New Page Settings panel does not fit in panel.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The New Page Settings panel for composer overflows the bottom of the preferences
dialog so that part of the Background IMage text box & button is cut off. 

Looks like space could be saved between the colour picker items by reducing the
margins by about 1-2px top and bottom. Also, the preview area looks terrible
being vertically stretched as it is. It should be a smaller size.

Comment 1

[Kathleen :Brade]

-->cmanske

Comment 2

[Charles Manske]

I agree. My original version had preview window only the the right of the color
buttons, but I was requested to stretch it to include the radio buttons.

Comment 3

[Kathleen :Brade]

Is this going to make the UI freeze or is it an ok change to make for the next 
milestone?

Comment 4

[Charles Manske]

The current version is definitely not acceptable, imho. But there's no text
changing, just layout rearrangement, so this isn't subject to the "UI freeze",
is it?

Comment 5

[Charles Manske]

*** Bug 80398 has been marked as a duplicate of this bug. ***

Comment 6

[Charles Manske]

Adding blocking the general pref resize bug 80392

Comment 7

[Charles Manske]

Attachment: Fix for dialog xul and tweak for modern theme CSS

Comment 8

[Charles Manske]

ready to review -- moving to 0.9.1 to checkin ASAP.

Comment 9

[Charles Manske]

Attachment: Even better fix: move text under "Default..." radio button to same line as radio button text

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Well, looks innocent enough. The best test for overrun is the Modern skin on 
Mac. This is because the widgets are at least as big as windows (puffy) and the 
text size in dialogs is small (9pt geneva or something), resulting in small 
ems. Make sure you're up to date as the widgets changed recently. Verify that 
it works there, and you have r/sr=ben (whichever you need). 

Comment 11

[chris hofmann]

is this ready to go in then?

Comment 12

[Charles Manske]

Just need someone to try it on Mac.

Comment 13

[Charles Manske]

Attachment: Another update: Save even more space by removing "Author" groupbox

Comment 14

[Charles Manske]

Attachment: Same as last patch, but use '<vbox' instead of '<box orient="vertical"'

Comment 15

[Blake Ross]

r=blake if you need it.

Comment 16

[Charles Manske]

Thanks! Do you have a Mac to test if this works? That's all I need to checkin.

Comment 17

[sairuh (rarely reading bugmail)]

hasn't this been fixed by ben's checkin for bug 80392? looks fine to me with a
recent build on linux [both modern and classic]. should this be resolved fixed
now?

Comment 18

[Charles Manske]

checked in.

Comment 19

[Charles Manske]

clearing status

Comment 20

[Charles Manske]

Oops! broke dialog by forgetting to close <vbox> with </vbox>!

Comment 21

[Charles Manske]

Attachment: Fixed closing <vbox> tags to use </vbox>

Comment 22

[Simon Fraser [no longer active]]

Why is that diff so big?

Comment 23

[timeless]

whitespace. reindentation presumably for different level count. do you want to 
set a preference for -uw patches? would you like a -uw version of this patch?

Comment 24

[Charles Manske]

Attachment: This diff shows change relative to checked in version

Comment 25

[Simon Fraser [no longer active]]

that's better. sr=sfraser

Comment 26

[Charles Manske]

Will checkin today.

Comment 27

[Charles Manske]

Checked in.

Comment 28

[K Chayka]

Attachment: Not fixed - screen shot from win32 build 2001051920, win98SE

Comment 29

[Charles Manske]

Still problems in Classic!

Comment 30

[Charles Manske]

I don't understand this: There's *plenty* of extra room in my debug build
from 5/18/01. Did someone make the panel even shorter? The total height in your
screenshot is definitely much shorter than in my debug build.

Comment 31

[Kathleen :Brade]

Can we get a longer editfield for the background image?  I barely have room to 
type a website in there (let alone a file!)

Comment 32

[timeless]

that last dialog used the wrong border type.  Preference dialgos are _not_ 
toolboxes.

Comment 33

[Charles Manske]

Timeless: I don't know what you mean in your last comment.

Comment 34

[timeless]

Attachment: what i mean

Comment 35

[Charles Manske]

Attachment: Reduce color button height and widen background image textbox width

Comment 36

[Charles Manske]

Shaved off more vertical space in classic -- saves at least 20px.
Edit field refuses to flex, but widened via minimum width CSS.

Comment 37

[Joe Hewitt (gone)]

sr=hewitt

Comment 38

[Charles Manske]

Attachment: What dialog looks like in my debug build

Comment 39

[timeless]

we could buy lots of space if we switched to a drop down listbox...
r=timeless, although blake would warn about using the style="..." attribute

Comment 40

[Charles Manske]

I just realized that Composer's "Page Colors and Background" dialog is close
to identical to the Editing Prefs dialog. They really should both look the
same. CC'ing appropriate localization people as instructed. (Patch to follow)

Comment 41

[Charles Manske]

Attachment: Same changes to pref dialog for the identical "Page Colors and Background" dialog

Comment 42

[danielmc]

Approved by L10n

Comment 43

[Charles Manske]

checked in

Comment 44

[sujay]

verified in 6/4 build.

Comment 45

[K Chayka]

Not fixed for me: win32 talkback build 2001061520, win98se
17-inch monitor, screen resolution 1280x1024 96dpi. Screen shot attached.

I can't see the bottom border of the Default Page Appearance panel, so I don't
know what else might be missing. Oddly enough, when I change the Win screen
display settings to use Large Fonts, content is not clipped.

Comment 46

[K Chayka]

Attachment: screen shot

Comment 47

[timeless]

K Chayka: please file a new bug, assign it to ben, however I still believe that 
your 'Caption Button' size is too small.  The summary should be something like
'small fonts, 96 dpi, 1280x1024 w/ tiny caption buttons results in overly small 
preference dialog'.

Comment 48

[K Chayka]

timeless: I don't know what you mean by "Caption Button". If you are referring
to something in the Windows Display Settings, then it is at whatever the default
for 96dpi is. I irregularly switch between Win Small and Large font settings,
but do not adjust any "Appearance" settings to go with either (does Win do this
by itself, perchance?). If "Caption Button" refers to something else altogether,
then please explain.

BTW, many of the other prefs panels have similar clipping (some worse than
others), and are seen on other platforms, mostly Mac.

Comment 49

[sairuh (rarely reading bugmail)]

btw, i've filed bug 86478 [per timeless' recommendation here]...pls adjust the
summary, add commentary there.