Closed Bug 77517 Opened 23 years ago Closed 23 years ago

Composer New Page Settings panel does not fit in panel.

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: bugs, Assigned: cmanske)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

Fix for dialog xul and tweak for modern theme CSS
11.04 KB, patch
Details | Diff | Splinter Review
Even better fix: move text under "Default..." radio button to same line as radio button text
11.75 KB, patch
Details | Diff | Splinter Review
Another update: Save even more space by removing "Author" groupbox
12.65 KB, patch
Details | Diff | Splinter Review
Same as last patch, but use '<vbox' instead of '<box orient="vertical"'
12.60 KB, patch
Details | Diff | Splinter Review
Fixed closing <vbox> tags to use </vbox>
12.60 KB, patch
Details | Diff | Splinter Review
This diff shows change relative to checked in version
923 bytes, patch
Details | Diff | Splinter Review
Not fixed - screen shot from win32 build 2001051920, win98SE
12.00 KB, image/gif
Details
what i mean
122.89 KB, image/jpeg
Details
Reduce color button height and widen background image textbox width
3.17 KB, patch
Details | Diff | Splinter Review
What dialog looks like in my debug build
14.50 KB, image/gif
Details
Same changes to pref dialog for the identical "Page Colors and Background" dialog
10.04 KB, patch
Details | Diff | Splinter Review
screen shot
12.37 KB, image/gif
Details 
The New Page Settings panel for composer overflows the bottom of the preferences
dialog so that part of the Background IMage text box & button is cut off. 

Looks like space could be saved between the colour picker items by reducing the
margins by about 1-2px top and bottom. Also, the preview area looks terrible
being vertically stretched as it is. It should be a smaller size.
-->cmanske
Assignee: beppe → cmanske
Summary: Composer New Page Settings panel does not fit in panel. → Composer New Page Settings panel does not fit in panel.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
I agree. My original version had preview window only the the right of the color
buttons, but I was requested to stretch it to include the radio buttons.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Is this going to make the UI freeze or is it an ok change to make for the next 
milestone?

The current version is definitely not acceptable, imho. But there's no text
changing, just layout rearrangement, so this isn't subject to the "UI freeze",
is it?

*** Bug 80398 has been marked as a duplicate of this bug. ***
Adding blocking the general pref resize bug 80392
Blocks: 80392
ready to review -- moving to 0.9.1 to checkin ASAP.
Whiteboard: FIX IN HAND need r=, sr=
Target Milestone: mozilla0.9.2 → mozilla0.9.1
Well, looks innocent enough. The best test for overrun is the Modern skin on 
Mac. This is because the widgets are at least as big as windows (puffy) and the 
text size in dialogs is small (9pt geneva or something), resulting in small 
ems. Make sure you're up to date as the widgets changed recently. Verify that 
it works there, and you have r/sr=ben (whichever you need). 
is this ready to go in then?
Just need someone to try it on Mac.
r=blake if you need it.
Thanks! Do you have a Mac to test if this works? That's all I need to checkin.
hasn't this been fixed by ben's checkin for bug 80392? looks fine to me with a
recent build on linux [both modern and classic]. should this be resolved fixed
now?
checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
clearing status
Whiteboard: FIX IN HAND need r=, sr=
Oops! broke dialog by forgetting to close <vbox> with </vbox>!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Why is that diff so big?

whitespace. reindentation presumably for different level count. do you want to 
set a preference for -uw patches? would you like a -uw version of this patch?
Severity: normal → major
Priority: -- → P2
that's better. sr=sfraser

Will checkin today.
Status: REOPENED → ASSIGNED
Whiteboard: FIX IN HAND
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND
Still problems in Classic!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I don't understand this: There's *plenty* of extra room in my debug build
from 5/18/01. Did someone make the panel even shorter? The total height in your
screenshot is definitely much shorter than in my debug build.

Can we get a longer editfield for the background image?  I barely have room to 
type a website in there (let alone a file!)

that last dialog used the wrong border type.  Preference dialgos are _not_ 
toolboxes.
Timeless: I don't know what you mean in your last comment.
Attached image what i mean — 

    
    

    
  
Shaved off more vertical space in classic -- saves at least 20px.
Edit field refuses to flex, but widened via minimum width CSS.
Status: REOPENED → ASSIGNED
Whiteboard: FIX IN HAND

    
    

    
  
sr=hewitt

    
    

    
  
we could buy lots of space if we switched to a drop down listbox...
r=timeless, although blake would warn about using the style="..." attribute

    
    

    
  
I just realized that Composer's "Page Colors and Background" dialog is close
to identical to the Editing Prefs dialog. They really should both look the
same. CC'ing appropriate localization people as instructed. (Patch to follow)

    
    

    
  
Approved by L10n

    
    

    
  
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Whiteboard: FIX IN HAND

    
    

    
  
verified in 6/4 build.
Status: RESOLVED → VERIFIED

    
    

    
  
Not fixed for me: win32 talkback build 2001061520, win98se
17-inch monitor, screen resolution 1280x1024 96dpi. Screen shot attached.

I can't see the bottom border of the Default Page Appearance panel, so I don't
know what else might be missing. Oddly enough, when I change the Win screen
display settings to use Large Fonts, content is not clipped.

    
    

    
  

      
      
      
      

        Attached image
          
        screen shot
        — 
      

    


  

    
    

    
  
K Chayka: please file a new bug, assign it to ben, however I still believe that 
your 'Caption Button' size is too small.  The summary should be something like
'small fonts, 96 dpi, 1280x1024 w/ tiny caption buttons results in overly small 
preference dialog'.

    
    

    
  
timeless: I don't know what you mean by "Caption Button". If you are referring
to something in the Windows Display Settings, then it is at whatever the default
for 96dpi is. I irregularly switch between Win Small and Large font settings,
but do not adjust any "Appearance" settings to go with either (does Win do this
by itself, perchance?). If "Caption Button" refers to something else altogether,
then please explain.

BTW, many of the other prefs panels have similar clipping (some worse than
others), and are seen on other platforms, mostly Mac.

    
    

    
  
btw, i've filed bug 86478 [per timeless' recommendation here]...pls adjust the
summary, add commentary there.
No longer blocks: 80392

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: