775231 - [ia] migrate data from tags to products for wiki documents

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

+++ This bug was initially created as a clone of Bug #768226 +++

Chunk 3:

* write a migration that migrates the data from the existing tags-based system to the new products based system
* update forms and views to use the new products table
* update the ui to use the new products table
* tweak indexing so that it's populating the tags index field with products

Putting this in the 2012.14 sprint and making it a 3 pointer--it's pretty involved.
(This may need to be broken up into further bugs.)

Comment 1

[Bram Pitoyo [:bram]]

I assume that the actual mapping process (not building the migration system) will be straightforward. For example, porting a tag called “Firefox” to a product called “Firefox”.

I don’t foresee any tag-to-product conversion problem, but let me know if there is anything that doesn’t map.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Copying a comment from https://github.com/mozilla/kitsune/pull/723 so I don't lose it.

"""
re: inheritance. That's currently done in code. So if you look at extract_document, there's code checking for the parent and if so, using the parent's tags. Then we do a bunch of similar stuff in views.

One way we could do this better is to have a getter on Document like this:

def get_products(self):
    if i have no parent, return my products
    if i have a parent, return my parent's products

Then we use get_products everywhere. That might clean some things up.

I would contend that'd be changes that should get made in the bug that involves all the code changes.
"""

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oops--I meant to take this originally. Grabbing it now.

Adding Matt and Verdi to the cc: list.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

We've got two products: firefox and mobile.

In the product table bug, Michael said:

"""
All articles "relevant to" Sync and Home should go into both the Firefox and the Firefox for mobile products. We won't have Sync or Home as products anymore.
"""

Thus, I'm going to migrate the following tags to products for all kb documents (tag -> product):

firefox        -> firefox
sync           -> firefox, mobile
persona        -> firefox
desktop        -> firefox
FxHome         -> firefox, mobile
Firefox 1.0    -> firefox
Firefox 6.0.2  -> firefox
Firefox 5.0    -> firefox
android        -> mobile
mobile         -> mobile

These two tags will just be removed since there are no products that match them:

marketplace
browserID


Is that ok with everyone?

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Minor note, Ricky pointed out that deleting the existing tags is stupid, so we'll do that in a later bug. w00t!

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I didn't get any feedback, so I'm going to assume this is ok and implement it now.

If it's not ok or you haven't looked at the plan, please do so soon.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Pull request: https://github.com/mozilla/kitsune/pull/743

Comment 8

[Bram Pitoyo [:bram]]

(In reply to Will Kahn-Greene [:willkg] from comment #6)
> I didn't get any feedback, so I'm going to assume this is ok and implement
> it now.
> 
> If it's not ok or you haven't looked at the plan, please do so soon.

Sorry for the lack of feedback. The migration scheme described on comment #4 looks good to me!

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/kitsune/commit/ae09810449821bb80d7c43da56d82c06ecbbb6a8

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: migration log for tags to products

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pushed to production just now. Marking as FIXED.