Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Don't visit the descendant frames for the nsChangeHint_UpdateEffects hint

RESOLVED FIXED in mozilla17

Status

()

Core
SVG
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

({perf})

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Seems like we shouldn't visit the descendant frames for the nsChangeHint_UpdateEffects hint.
Created attachment 643906 [details] [diff] [review]
patch
Attachment #643906 - Flags: review?(roc)
Comment on attachment 643906 [details] [diff] [review]
patch

Review of attachment 643906 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know whether these ForceCompare changes are going to be a problem. Maybe we're not doing the right tradeoffs here...

::: layout/style/nsStyleStruct.h
@@ +315,5 @@
>    nsChangeHint CalcDifference(const nsStyleBackground& aOther) const;
>  #ifdef DEBUG
>    static nsChangeHint MaxDifference();
>  #endif
> +  static bool ForceCompare() { return true; }

Better check this with dbaron.
Attachment #643906 - Flags: review?(roc)
Attachment #643906 - Flags: review?(dbaron)
Attachment #643906 - Flags: review+
Attachment #643906 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/0a00993c6ebe
Target Milestone: --- → mozilla17

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0a00993c6ebe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Keywords: perf

Updated

5 years ago
Depends on: 782888

Updated

5 years ago
Depends on: 788919
You need to log in before you can comment on or make changes to this bug.