Closed Bug 775304 Opened 7 years ago Closed 7 years ago

Don't visit the descendant frames for the nsChangeHint_UpdateEffects hint

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Keywords: perf)

Attachments

(1 file)

Seems like we shouldn't visit the descendant frames for the nsChangeHint_UpdateEffects hint.
Attached patch patchSplinter Review
Attachment #643906 - Flags: review?(roc)
Comment on attachment 643906 [details] [diff] [review]
patch

Review of attachment 643906 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know whether these ForceCompare changes are going to be a problem. Maybe we're not doing the right tradeoffs here...

::: layout/style/nsStyleStruct.h
@@ +315,5 @@
>    nsChangeHint CalcDifference(const nsStyleBackground& aOther) const;
>  #ifdef DEBUG
>    static nsChangeHint MaxDifference();
>  #endif
> +  static bool ForceCompare() { return true; }

Better check this with dbaron.
Attachment #643906 - Flags: review?(roc)
Attachment #643906 - Flags: review?(dbaron)
Attachment #643906 - Flags: review+
Attachment #643906 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/0a00993c6ebe
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 782888
You need to log in before you can comment on or make changes to this bug.