Last Comment Bug 775304 - Don't visit the descendant frames for the nsChangeHint_UpdateEffects hint
: Don't visit the descendant frames for the nsChangeHint_UpdateEffects hint
Status: RESOLVED FIXED
: perf
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jonathan Watt [:jwatt]
:
: Jet Villegas (:jet)
Mentors:
Depends on: 782888 788919
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-18 14:26 PDT by Jonathan Watt [:jwatt]
Modified: 2012-09-06 07:32 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.14 KB, patch)
2012-07-19 10:20 PDT, Jonathan Watt [:jwatt]
roc: review+
dbaron: review+
Details | Diff | Splinter Review

Description Jonathan Watt [:jwatt] 2012-07-18 14:26:58 PDT
Seems like we shouldn't visit the descendant frames for the nsChangeHint_UpdateEffects hint.
Comment 1 Jonathan Watt [:jwatt] 2012-07-19 10:20:02 PDT
Created attachment 643906 [details] [diff] [review]
patch
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2012-07-19 10:39:28 PDT
Comment on attachment 643906 [details] [diff] [review]
patch

Review of attachment 643906 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know whether these ForceCompare changes are going to be a problem. Maybe we're not doing the right tradeoffs here...

::: layout/style/nsStyleStruct.h
@@ +315,5 @@
>    nsChangeHint CalcDifference(const nsStyleBackground& aOther) const;
>  #ifdef DEBUG
>    static nsChangeHint MaxDifference();
>  #endif
> +  static bool ForceCompare() { return true; }

Better check this with dbaron.
Comment 4 Ed Morley [:emorley] 2012-07-20 06:44:43 PDT
https://hg.mozilla.org/mozilla-central/rev/0a00993c6ebe

Note You need to log in before you can comment on or make changes to this bug.