788919 - "Assertion failure: IsElement()" changing markerStart on <svg:text>

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

###!!! ASSERTION: Shouldn't be trying to restyle non-elements directly: '!aContent || aContent->IsElement()', file ../../../layout/base/nsStyleChangeList.cpp, line 65

###!!! ASSERTION: aFrame's content should be an element: 'aFrame->GetContent()->IsElement()', file ../../../../../layout/svg/base/src/nsSVGEffects.cpp, line 480

Assertion failure: IsElement(), at ../../../../dist/include/mozilla/dom/Element.h:340

Comment 1

[Jesse Ruderman]

Attachment: stacks

Comment 2

[Boris Zbarsky [:bzbarsky]]

This is the same issue as bug 782888.

The problem is that markerStart inherits by default (why???) and in particular gets inherited into textframes.  So we're trying to restyle a textframe.

We really need to do _something_ here.  Bug 775304 caused us to violate some invariants.  We need to either stop doing that (either by backing out that bug or in some other way), or fix all the code that depended on those invariants.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds like we should back it out, unless there's a big reason the optimization is important.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(And we should add comments pointing out that hints that result from inherited properties can't be non-inherited.)

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

backout of 775304 in bug 782888 is already approved for 17, but assigning this one to Jonathan anyway to make sure that the backout does what is intended for this bug.

Comment 6

[Robert Longson [:longsonr]]

Fixed by Cameron's patch in bug 782888

Comment 7

[Virgil Dicu [:virgil] [QA]]

Tested on:
Firefox 17.0 Beta Debug
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121020072533

I opened Firefox from Terminal and ran the testcase from comment 0. After running the testcase no assertion message was found and no crashes occurred.

Comment 8

[Virgil Dicu [:virgil] [QA]]

Verified on
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:18.0) Gecko/20121130 Firefox/18.0 Beta Debug
Build ID:  20121130125945

I started Firefox Nightly Debug 18.0 Beta from Terminal and ran testcase from comment 0. No assertion found after running the testcase.

Comment 9

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old