Closed Bug 775394 Opened 9 years ago Closed 9 years ago

Use Services.io instead of Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService) in xpcshell test

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 18.0

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix (obsolete) — Splinter Review
No description provided.
Attachment #643706 - Flags: review?(mconley)
Summary: Use Services.io instead of Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService) → Use Services.io instead of Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService) in xpcshell test
Nice work :)
Blocks: 720356
Comment on attachment 643706 [details] [diff] [review]
Fix

Review of attachment 643706 [details] [diff] [review]:
-----------------------------------------------------------------

This is awesome - thanks Hiro!

I've only inspected these tests, and haven't run the patch. I assume these all run correctly?

Assuming that, and with my one little nit fixed, r=me. Great work!

::: mailnews/news/test/unit/test_bug37465.js
@@ +8,5 @@
>    server.start(NNTP_PORT);
>  
>    // Correct URI?
> +  let uri = Services.io.newURI("news://localhost:1143/1@regular.invalid",
> +                               null,

Let's put this last null on the same line as the one before.
Attachment #643706 - Flags: review?(mconley) → review+
The last try server result had some build errors.

Now I pushed to a try again for the safety.
Assignee: nobody → hiikezoe
Attachment #643706 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #645910 - Flags: review+
What's the status on this ?
Hm - I guess it never got checkin-needed.

This is about a month old - I'll make sure the patch still applies, and then set the flag.
https://hg.mozilla.org/comm-central/rev/2bdd449748dd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.