775394 - Use Services.io instead of Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService) in xpcshell test

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: Fix

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I just pushed a try:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=98e8fc1442a3

Comment 2

[:aceman]

Nice work :)

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 643706 [details] [diff] [review]
Fix

Review of attachment 643706 [details] [diff] [review]:
-----------------------------------------------------------------

This is awesome - thanks Hiro!

I've only inspected these tests, and haven't run the patch. I assume these all run correctly?

Assuming that, and with my one little nit fixed, r=me. Great work!

::: mailnews/news/test/unit/test_bug37465.js
@@ +8,5 @@
>    server.start(NNTP_PORT);
>  
>    // Correct URI?
> +  let uri = Services.io.newURI("news://localhost:1143/[e-mail]",
> +                               null,

Let's put this last null on the same line as the one before.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: null position fix

The last try server result had some build errors.

Now I pushed to a try again for the safety.

Comment 5

[Ludovic Hirlimann [:Usul]]

What's the status on this ?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hm - I guess it never got checkin-needed.

This is about a month old - I'll make sure the patch still applies, and then set the flag.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Ok, this still looks good.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/2bdd449748dd