Closed
Bug 720356
Opened 12 years ago
Closed 5 years ago
Switch to Services.jsm in Thunderbird js files
Categories
(Thunderbird :: General, task, P5)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Unassigned)
References
Details
(Keywords: meta, Whiteboard: [please do not close])
Using Services.jsm will clean up the readability of our code a bit, and should avoid the costs the getService call each time we want a service.
This will try to cover both /mail and /mailnews in the same way as bug 720358.
Component: General → Backend
Product: Thunderbird → MailNews Core
QA Contact: general → backend
See Also: → 720358
Severity: normal → enhancement
Component: Backend → General
Product: MailNews Core → Thunderbird
QA Contact: backend → general
I've checked the trunk and the only remaining services to be converted remain in the test files.
Assignee: acelists → archaeopteryx
Comment 3•11 years ago
|
||
Can you please provide examples? /calendar/: should be converted: bug 795102 /chat/: has no such interfaces /editor/ has no such interfaces (checked two months ago or so) /ldap/: Didn't touch this because there was discussion about replacing it with a different implementation /mail/ and /mailnews/: should be converted: bug 852690 /suite/: Leaving the work to the SeaMonkey people
Updated•11 years ago
|
Flags: needinfo?(acelists)
Comment 4•11 years ago
|
||
Ok, forget about the list in comment #3, that was for MailServices.
I mean /mailnews/test and /mail/test http://mxr.mozilla.org/comm-central/search?string=preferences-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central http://mxr.mozilla.org/comm-central/search?string=io-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Flags: needinfo?(acelists)
Comment 6•11 years ago
|
||
(In reply to :aceman from comment #2) > I've checked the trunk and the only remaining services to be converted > remain in the test files. Hmmm ... Might bug 874690 be related to this?
Probably not, converting the tests may cause more problems like bug 874690, but as I understand it it is not done yet.
I could convert some remaining occurrences (maybe new Services added?) and some test files (which do not redefine the builtin Services) in bug 1508415. Aryx, do you see anything more to be done here?
Flags: needinfo?(aryx.bugmail)
Comment 9•5 years ago
|
||
Sorry for the late reply. With the uses covered by bug 1508415, imports of the modules which are part of Services outside that file can be detected with https://hg.mozilla.org/mozilla-central/file/tip/tools/lint/eslint/eslint-plugin-mozilla/lib/rules/use-services.js - did that eslint check fail before your tests? A similar check could be added for MailServices.jsm.
Flags: needinfo?(aryx.bugmail)
Updated•5 years ago
|
Assignee: aryx.bugmail → nobody
Status: ASSIGNED → NEW
Comment 10•5 years ago
|
||
We are gradually adding new subfolders of c-c to be processed by eslint so hopefully any remaining uses (or new ones) will be found.
If you do not see any more uses that you want to fix in this bug (or file a dependent bug now) I'd suggest we close this (and bug 720358) as it is quite old now and the work is basically done.
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•