If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Switch to Services.jsm in Thunderbird js files

ASSIGNED
Assigned to

Status

Thunderbird
General
P5
enhancement
ASSIGNED
6 years ago
4 years ago

People

(Reporter: standard8, Assigned: aryx)

Tracking

(Depends on: 1 bug, {meta})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [please do not close])

(Reporter)

Description

6 years ago
Using Services.jsm will clean up the readability of our code a bit, and should avoid the costs the getService call each time we want a service.

Updated

6 years ago
Depends on: 714604

Updated

6 years ago
Depends on: 707789

Updated

6 years ago
Status: NEW → ASSIGNED
Priority: -- → P5

Comment 1

6 years ago
This will try to cover both /mail and /mailnews in the same way as bug 720358.

Updated

6 years ago
Depends on: 721517

Updated

6 years ago
Depends on: 722168

Updated

6 years ago
Depends on: 722187

Updated

6 years ago
Depends on: 726737

Updated

6 years ago
Depends on: 732807

Updated

6 years ago
Component: General → Backend
Product: Thunderbird → MailNews Core
QA Contact: general → backend
See Also: → bug 720358

Updated

6 years ago
Severity: normal → enhancement
Component: Backend → General
Product: MailNews Core → Thunderbird
QA Contact: backend → general

Updated

6 years ago
Depends on: 733496
Depends on: 734544
Depends on: 734547

Updated

6 years ago
Depends on: 736870

Updated

6 years ago
Depends on: 738810

Updated

6 years ago
Depends on: 738991
Blocks: 451578

Updated

6 years ago
Depends on: 748965

Updated

5 years ago
Depends on: 754579

Updated

5 years ago
Depends on: 758911

Updated

5 years ago
Depends on: 758915

Updated

5 years ago
Depends on: 758951

Updated

5 years ago
Depends on: 758979

Updated

5 years ago
Depends on: 763106

Updated

5 years ago
Depends on: 763437

Updated

5 years ago
Depends on: 775394

Updated

5 years ago
Depends on: 776705

Updated

5 years ago
Depends on: 793599
Depends on: 794909
Depends on: 795152

Updated

5 years ago
Depends on: 804004

Updated

5 years ago
Depends on: 804008

Updated

5 years ago
No longer depends on: 804008

Updated

5 years ago
Whiteboard: [please do not close]

Comment 2

5 years ago
I've checked the trunk and the only remaining services to be converted remain in the test files.
Assignee: acelists → archaeopteryx
Can you please provide examples?

/calendar/: should be converted: bug 795102
/chat/: has no such interfaces
/editor/ has no such interfaces (checked two months ago or so)
/ldap/: Didn't touch this because there was discussion about replacing it with a different implementation
/mail/ and /mailnews/: should be converted: bug 852690
/suite/: Leaving the work to the SeaMonkey people
Flags: needinfo?(acelists)
Ok, forget about the list in comment #3, that was for MailServices.

Comment 5

5 years ago
I mean /mailnews/test and /mail/test
http://mxr.mozilla.org/comm-central/search?string=preferences-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

http://mxr.mozilla.org/comm-central/search?string=io-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
Flags: needinfo?(acelists)
(In reply to :aceman from comment #2)
> I've checked the trunk and the only remaining services to be converted
> remain in the test files.

Hmmm ... Might bug 874690 be related to this?

Comment 7

4 years ago
Probably not, converting the tests may cause more problems like bug 874690, but as I understand it it is not done yet.

Updated

4 years ago
Depends on: 863617

Updated

4 years ago
No longer blocks: 451578

Updated

4 years ago
Blocks: 957184
You need to log in before you can comment on or make changes to this bug.