Closed Bug 720356 Opened 9 years ago Closed 2 years ago
Switch to Services
.jsm in Thunderbird js files
Using Services.jsm will clean up the readability of our code a bit, and should avoid the costs the getService call each time we want a service.
This will try to cover both /mail and /mailnews in the same way as bug 720358.
Component: General → Backend
Product: Thunderbird → MailNews Core
QA Contact: general → backend
See Also: → 720358
Severity: normal → enhancement
Component: Backend → General
Product: MailNews Core → Thunderbird
QA Contact: backend → general
Depends on: 794909
Depends on: 795152
I've checked the trunk and the only remaining services to be converted remain in the test files.
Assignee: acelists → archaeopteryx
Can you please provide examples? /calendar/: should be converted: bug 795102 /chat/: has no such interfaces /editor/ has no such interfaces (checked two months ago or so) /ldap/: Didn't touch this because there was discussion about replacing it with a different implementation /mail/ and /mailnews/: should be converted: bug 852690 /suite/: Leaving the work to the SeaMonkey people
Ok, forget about the list in comment #3, that was for MailServices.
I mean /mailnews/test and /mail/test http://mxr.mozilla.org/comm-central/search?string=preferences-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central http://mxr.mozilla.org/comm-central/search?string=io-service&find=%2Fmail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
(In reply to :aceman from comment #2) > I've checked the trunk and the only remaining services to be converted > remain in the test files. Hmmm ... Might bug 874690 be related to this?
Probably not, converting the tests may cause more problems like bug 874690, but as I understand it it is not done yet.
I could convert some remaining occurrences (maybe new Services added?) and some test files (which do not redefine the builtin Services) in bug 1508415. Aryx, do you see anything more to be done here?
Assignee: aryx.bugmail → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.