Last Comment Bug 775451 - Choose a suitable pre-render size for async pan/zoomed content
: Choose a suitable pre-render size for async pan/zoomed content
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Doug Sherk (:drs) (inactive)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 745136
  Show dependency treegraph
 
Reported: 2012-07-19 02:55 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-08-09 04:52 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
?
+


Attachments
Reduce amount of diagonal checkerboarding (5.73 KB, patch)
2012-08-04 00:29 PDT, Doug Sherk (:drs) (inactive)
cjones.bugs: review+
Details | Diff | Splinter Review
Reduce amount of diagonal checkerboarding (7.57 KB, patch)
2012-08-06 18:45 PDT, Doug Sherk (:drs) (inactive)
bugzilla: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-19 02:55:50 PDT
In the initial landing, we're only drawing the window size, which means each pan results in "checkerboarding".  It's relatively easy to render more content, but we need to pass more information from gecko to apzc and fix up some offset calculations.
Comment 1 Doug Sherk (:drs) (inactive) 2012-08-04 00:29:56 PDT
Created attachment 648963 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

We'll probably have to keep tweaking this forever, but this patch should reduce diagonal checkerboarding which seems to be the worst thing we're still experiencing. I also added code to take into account the velocity directly. If we're going really fast, we try to prerender a larger area than if we're going slower. This is again more useful diagonally since we may be going fast along one axis and slow along another, in which case we want to prerender less of one and more of another.
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-06 12:03:53 PDT
Comment on attachment 648963 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

>diff --git a/gfx/layers/ipc/AsyncPanZoomController.cpp b/gfx/layers/ipc/AsyncPanZoomController.cpp

>+    if (fabsf(velocity.x) > MIN_SKATE_SPEED) {

Factor out this code and share it.

r=me with that.
Comment 3 Doug Sherk (:drs) (inactive) 2012-08-06 18:45:50 PDT
Created attachment 649515 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

Addressed review comments, r+ carried.
Comment 4 Doug Sherk (:drs) (inactive) 2012-08-07 18:54:22 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/32cc8084d1b7
Comment 5 Phil Ringnalda (:philor) 2012-08-07 21:07:36 PDT
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d8878c0bd67c - something in that push made Linux oddly unhappy.
Comment 6 Ed Morley [:emorley] 2012-08-08 09:29:38 PDT
https://hg.mozilla.org/mozilla-central/rev/32cc8084d1b7
Comment 7 Doug Sherk (:drs) (inactive) 2012-08-08 11:04:30 PDT
This was backed out.
Comment 8 Doug Sherk (:drs) (inactive) 2012-08-08 13:40:22 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e0038507ff
Comment 9 Ed Morley [:emorley] 2012-08-09 04:52:29 PDT
https://hg.mozilla.org/mozilla-central/rev/a2e0038507ff

Note You need to log in before you can comment on or make changes to this bug.