Choose a suitable pre-render size for async pan/zoomed content

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: drs)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(blocking-kilimanjaro:?, blocking-basecamp:+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In the initial landing, we're only drawing the window size, which means each pan results in "checkerboarding".  It's relatively easy to render more content, but we need to pass more information from gecko to apzc and fix up some offset calculations.
blocking-basecamp: ? → +
(Assignee)

Comment 1

5 years ago
Created attachment 648963 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

We'll probably have to keep tweaking this forever, but this patch should reduce diagonal checkerboarding which seems to be the worst thing we're still experiencing. I also added code to take into account the velocity directly. If we're going really fast, we try to prerender a larger area than if we're going slower. This is again more useful diagonally since we may be going fast along one axis and slow along another, in which case we want to prerender less of one and more of another.
Assignee: nobody → bugzilla
Attachment #648963 - Flags: review?(jones.chris.g)
Comment on attachment 648963 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

>diff --git a/gfx/layers/ipc/AsyncPanZoomController.cpp b/gfx/layers/ipc/AsyncPanZoomController.cpp

>+    if (fabsf(velocity.x) > MIN_SKATE_SPEED) {

Factor out this code and share it.

r=me with that.
Attachment #648963 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 649515 [details] [diff] [review]
Reduce amount of diagonal checkerboarding

Addressed review comments, r+ carried.
Attachment #648963 - Attachment is obsolete: true
Attachment #649515 - Flags: review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/32cc8084d1b7
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d8878c0bd67c - something in that push made Linux oddly unhappy.

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/32cc8084d1b7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Comment 7

5 years ago
This was backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e0038507ff

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a2e0038507ff
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.