775643 - Inconsistency - Marketplace validator is requiring icons to exist in the manifest, when in fact icons being specified is optional

Status: RESOLVED DUPLICATE of bug 760343

(Marketplace Graveyard :: Validation, defect)

Description

[Jason Smith [:jsmith]]

The validator on marketplace currently enforces and indicates an error if a user submits a manifest that does not contain any icons. This is inconsistent with the specification of our apps documentation for manifests (https://developer.mozilla.org/en/Apps/Manifest), which is likely to cause some level of confusion, as you'll see the following error:

Error: The 'root' node of the Web App Manifest expects a `icons` element, which was not found.

Error: You can find more information at https://developer.mozilla.org/en/OpenWebApps/The_Manifest

If I was developer, I'd be confused here. I'd see the docs and think "This isn't required according to the doc, but marketplace is saying it's required." We should follow the rules according to the specification defined for our app manifests.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

The manifest changes were completed but not the changes to the Submit App Details and Edit Details pages. See bug 760343. Basta, feel free to dupe/or keep this bug open. Your call.

Comment 2

[Wil Clouser [:clouserw]]

I think this comes from poor communication on my part in the other bug.  We should require icons to list apps on the marketplace, but that restriction should be in the dev tools, not the manifest validator.  The validator should follow the published spec.

Comment 3

[Matt Basta [:basta]]

The restriction is only in place if the validator is called with the "listed" flag to indicate that it's being run from Marketplace. If you were to run it from the terminal with the unlisted flag, you wouldn't get that error. The same goes with the standalone validator.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #2)
> I think this comes from poor communication on my part in the other bug.  We
> should require icons to list apps on the marketplace, but that restriction
> should be in the dev tools, not the manifest validator.  The validator
> should follow the published spec.

But if we don't require icons in the validator (step 2) but we require them on the details page (step 3), then the icons that get extracted when you natively install are not there.

Comment 5

[krupa raj[:krupa]]

This was discussed in #openwebapps and anant mentioned that though he'd be hesitant to add it as a required field in the manifest, he'd support Marketplace marking it as required.

Adding a note in MDN about this being a required field to submit apps in Marketplace should suffice.

Comment 6

[Matt Basta [:basta]]

That's already been done. MDN and the spec on github have already been updated.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Matt Basta [:basta] from comment #6)
> That's already been done. MDN and the spec on github have already been
> updated.

I don't see it here - https://developer.mozilla.org/en/Apps/Manifest. Was it updated on some staging server?

(In reply to krupa raj 82[:krupa] from comment #5)
> This was discussed in #openwebapps and anant mentioned that though he'd be
> hesitant to add it as a required field in the manifest, he'd support
> Marketplace marking it as required.

So long as this doesn't negatively affect apps that already exist on the marketplace, such that we can get them to update their manifest, and it's clear in the docs, then that's fine.

Comment 8

[Matt Basta [:basta]]

> I don't see it here - https://developer.mozilla.org/en/Apps/Manifest. Was it updated on some staging server?

The updated version can be found here: https://developer-new.mozilla.org/en-US/docs/Apps/The_Manifest

Comment 9

[Wil Clouser [:clouserw]]

This is on the page in comment 8 now.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

This was not fixed. Yes, we require 128-px icons during validation, but on the Submit Details step you can replace the icon with a smaller one and proceed just fine. This will be properly fixed with bug 760343.